Skip to content

Commit b5e6ad3

Browse files
Make new test more precise in expected file
1 parent 0354272 commit b5e6ad3

1 file changed

Lines changed: 11 additions & 10 deletions

File tree

UnityDataTool.Tests/ExtractedTypeTreeTests.cs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ public class ExtractedTypeTreeTests
1313
private string m_TestOutputFolder;
1414
private string m_DataFolder;
1515
private string m_SerializedFile;
16+
private string m_SerializedFilePath;
1617
private string m_TypeTreeDataFile;
1718

1819
[OneTimeSetUp]
@@ -22,7 +23,8 @@ public void OneTimeSetup()
2223
Directory.CreateDirectory(m_TestOutputFolder);
2324

2425
m_DataFolder = Path.Combine(TestContext.CurrentContext.TestDirectory, "Data", "ExtractedTypeTree");
25-
m_SerializedFile = Path.Combine(m_DataFolder, "sfwithextractedtypetrees1");
26+
m_SerializedFile = "sfwithextractedtypetrees1";
27+
m_SerializedFilePath = Path.Combine(m_DataFolder, m_SerializedFile);
2628
m_TypeTreeDataFile = Path.Combine(m_DataFolder, "sfwithextractedtypetrees1.typetreedata");
2729
}
2830

@@ -94,21 +96,20 @@ public async Task Analyze_WithoutTypeTreeData_ReportsFailure()
9496
public async Task Dump_WithTypeTreeData_Succeeds(
9597
[Values("-d", "--typetree-data")] string option)
9698
{
97-
Assert.AreEqual(0, await Program.Main(new string[] { "dump", m_SerializedFile, option, m_TypeTreeDataFile }));
99+
Assert.AreEqual(0, await Program.Main(new string[] { "dump", m_SerializedFilePath, "-o", m_TestOutputFolder, option, m_TypeTreeDataFile }));
100+
var outputFile = Path.Combine(m_TestOutputFolder, m_SerializedFile + ".txt");
101+
var txt = File.ReadAllText(outputFile);
98102

99-
var outputFiles = Directory.GetFiles(m_TestOutputFolder, "*.txt");
100-
Assert.IsNotEmpty(outputFiles, "Expected dump output files when TypeTree data file is provided");
101-
foreach (var f in outputFiles)
102-
{
103-
var txt = File.ReadAllText(f);
104-
Assert.IsTrue(txt.Contains("m_GameObject (PPtr<GameObject>)"));
105-
}
103+
// Confirm that the file contains an expected line (based on the content of this file)
104+
Assert.IsTrue(txt.Contains("m_GameObject (PPtr<GameObject>)"));
105+
106+
File.Delete(outputFile);
106107
}
107108

108109
[Test]
109110
public async Task Dump_WithoutTypeTreeData_Fails()
110111
{
111-
Assert.AreNotEqual(0, await Program.Main(new string[] { "dump", m_SerializedFile }));
112+
Assert.AreNotEqual(0, await Program.Main(new string[] { "dump", m_SerializedFilePath }));
112113
}
113114

114115
[Test]

0 commit comments

Comments
 (0)