Open
Conversation
mfe
changed the title
mfe
force-pushed
the
UUM-137643_fix_coreclr_errors
branch
from
b8c4202 to
52abb9f
Compare
…stead of int for improved compatibility and precision. Update related collections and methods accordingly.
LeoUnity
reviewed
Apr 7, 2026
| @@ -1,24 +1,24 @@ | |||
| test_editors: | |||
| - version: 2021.3 | |||
Contributor
There was a problem hiding this comment.
shouldn't we also remove this and upgrade the minimum unity version to 6000.0?
Same with romotion_test_editors
Collaborator
Author
There was a problem hiding this comment.
It's the minimum version of the package, so we have to keep the job for promotion.
LeoUnity
approved these changes
Apr 7, 2026
Contributor
LeoUnity
left a comment
LeoUnity
left a comment
There was a problem hiding this comment.
Changes looks good to me, we do have a test failure on win trunk unfortunately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ticket/Jira #: UUM-137643
Compilation errors in the console:
error CS0619: 'Object.GetInstanceID()' is obsolete: 'GetInstanceID is deprecated. Use GetEntityId instead.
Warnings:
Logs: C:\build\output\unity\com.unity.recorder\com.unity.recorder\Editor\Sources\BaseTextureRecorder.cs(167,92): warning CS0618: 'FindObjectsSortMode' is obsolete: 'FindObjectsSortMode has been deprecated. Use the FindObjectsByType overloads that do not take a FindObjectsSortMode parameter.' (C:\build\output\unity\com.unity.recorder\com.unity.recorder\Editor\Sources\BaseTextureRecorder.cs:167)
Also replaced renderPipelineAsset by defaultRenderPipeline.
Testing
Functional Testing status:
Performance Testing status:
Overall Product Risks
Complexity:
Halo Effect:
Documentation & UX Writing
Additional information
Note to reviewers:
Reminder: