Noel stephens unity player cube controller editor update (#1375)

Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>
Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>

Author: 3 people

docs/learn/distributed-authority-quick-start.md

@@ -180,49 +180,25 @@ public class PlayerCubeControllerEditor : NetworkTransformEditor
     private SerializedProperty m_Speed;
     private SerializedProperty m_ApplyVerticalInputToZAxis;
 
-
     public override void OnEnable()
     {
         m_Speed = serializedObject.FindProperty(nameof(PlayerCubeController.Speed));
         m_ApplyVerticalInputToZAxis = serializedObject.FindProperty(nameof(PlayerCubeController.ApplyVerticalInputToZAxis));
         base.OnEnable();
     }
 
+    private void DisplayPlayerCubeControllerProperties()
+    {
+        EditorGUILayout.PropertyField(m_Speed);
+        EditorGUILayout.PropertyField(m_ApplyVerticalInputToZAxis);
+    }
 
     public override void OnInspectorGUI()
     {
         var playerCubeController = target as PlayerCubeController;
-
-
-        playerCubeController.PlayerCubeControllerPropertiesVisible = EditorGUILayout.BeginFoldoutHeaderGroup(playerCubeController.PlayerCubeControllerPropertiesVisible, $"{nameof(PlayerCubeController)} Properties");
-        if (playerCubeController.PlayerCubeControllerPropertiesVisible)
-        {
-            EditorGUILayout.PropertyField(m_Speed);
-            EditorGUILayout.PropertyField(m_ApplyVerticalInputToZAxis);
-        }
-        EditorGUILayout.EndFoldoutHeaderGroup();
-
-
-        EditorGUILayout.Space();
-
-
-        playerCubeController.NetworkTransformPropertiesVisible = EditorGUILayout.BeginFoldoutHeaderGroup(playerCubeController.NetworkTransformPropertiesVisible, $"{nameof(NetworkTransform)} Properties");
-        if (playerCubeController.NetworkTransformPropertiesVisible)
-        {
-            // End the header group prior to invoking the base OnInspectorGUID in order to avoid nested
-            // foldout groups.
-            EditorGUILayout.EndFoldoutHeaderGroup();
-            // If NetworkTransform properties are visible, then both the properties any modified properties
-            // will be applied.
-            base.OnInspectorGUI();
-        }
-        else
-        {
-            // End the header group
-            EditorGUILayout.EndFoldoutHeaderGroup();
-            // If NetworkTransform properties are not visible, then make sure we apply any modified properties.
-            serializedObject.ApplyModifiedProperties();
-        }
+        void SetExpanded(bool expanded) { playerCubeController.PlayerCubeControllerPropertiesVisible = expanded; };
+        DrawFoldOutGroup<PlayerCubeController>(playerCubeController.GetType(), DisplayPlayerCubeControllerProperties, playerCubeController.PlayerCubeControllerPropertiesVisible, SetExpanded);
+        base.OnInspectorGUI();
     }
 }
 #endif
@@ -235,17 +211,11 @@ public class PlayerCubeController : NetworkTransform
     // within the inspector view will be saved and restored the next time the
     // asset/prefab is viewed.
     public bool PlayerCubeControllerPropertiesVisible;
-    public bool NetworkTransformPropertiesVisible;
 #endif
-
-
     public float Speed = 10;
     public bool ApplyVerticalInputToZAxis;
-
-
     private Vector3 m_Motion;
 
-
     private void Update()
     {
         // If not spawned or we don't have authority, then don't update
@@ -254,12 +224,10 @@ public class PlayerCubeController : NetworkTransform
             return;
         }
 
-
         // Handle acquiring and applying player input
         m_Motion = Vector3.zero;
         m_Motion.x = Input.GetAxis("Horizontal");
 
-
         // Determine whether the vertical input is applied to the Y or Z axis
         if (!ApplyVerticalInputToZAxis)
         {
@@ -270,7 +238,6 @@ public class PlayerCubeController : NetworkTransform
             m_Motion.z = Input.GetAxis("Vertical");
         }
 
-
         // If there is any player input magnitude, then apply that amount of
         // motion to the transform
         if (m_Motion.magnitude > 0)