Skip to content

Commit 1b42bc0

Browse files
committed
Merge branch 'develop-2.0.0' into chore/remove-spawn-state-exceptions-network-object
# Conflicts: # com.unity.netcode.gameobjects/CHANGELOG.md
2 parents 314c913 + e22eaa9 commit 1b42bc0

File tree

5 files changed

+20
-17
lines changed

5 files changed

+20
-17
lines changed

Tools/scripts/ReleaseAutomation/release_config.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,16 +98,16 @@ def __init__(self):
9898

9999
self.yamato_build_automation_configs = [
100100
{
101-
"job_name": "Build Sample for Windows with minimal supported editor (2022.3), burst ON, IL2CPP",
101+
"job_name": "Build Sample for Windows with minimal supported editor (6000.0), burst ON, IL2CPP",
102102
"variables": [
103103
{ "key": "BURST_ON_OFF", "value": "on" },
104104
{ "key": "PLATFORM_WIN64_MAC_ANDROID", "value": "win64" },
105105
{ "key": "SCRIPTING_BACKEND_IL2CPP_MONO", "value": "il2cpp" },
106-
{ "key": "UNITY_VERSION", "value": "2022.3" } # Minimal supported editor
106+
{ "key": "UNITY_VERSION", "value": "6000.0" } # Minimal supported editor
107107
]
108108
},
109109
{
110-
"job_name": "Build Sample for Windows with latest functional editor (6000.2), burst ON, IL2CPP",
110+
"job_name": "Build Sample for Windows with latest functional editor (6000.3), burst ON, IL2CPP",
111111
"variables": [
112112
{ "key": "BURST_ON_OFF", "value": "on" },
113113
{ "key": "PLATFORM_WIN64_MAC_ANDROID", "value": "win64" },
@@ -125,16 +125,16 @@ def __init__(self):
125125
]
126126
},
127127
{
128-
"job_name": "Build Sample for MacOS with minimal supported editor (2022.3), burst OFF, Mono",
128+
"job_name": "Build Sample for MacOS with minimal supported editor (6000.0), burst OFF, Mono",
129129
"variables": [
130130
{ "key": "BURST_ON_OFF", "value": "off" },
131131
{ "key": "PLATFORM_WIN64_MAC_ANDROID", "value": "mac" },
132132
{ "key": "SCRIPTING_BACKEND_IL2CPP_MONO", "value": "mono" },
133-
{ "key": "UNITY_VERSION", "value": "2022.3" } # Minimal supported editor
133+
{ "key": "UNITY_VERSION", "value": "6000.0" } # Minimal supported editor
134134
]
135135
},
136136
{
137-
"job_name": "Build Sample for MacOS with latest functional editor (6000.2), burst OFF, Mono",
137+
"job_name": "Build Sample for MacOS with latest functional editor (6000.3), burst OFF, Mono",
138138
"variables": [
139139
{ "key": "BURST_ON_OFF", "value": "off" },
140140
{ "key": "PLATFORM_WIN64_MAC_ANDROID", "value": "mac" },
@@ -152,16 +152,16 @@ def __init__(self):
152152
]
153153
},
154154
{
155-
"job_name": "Build Sample for Android with minimal supported editor (2022.3), burst ON, IL2CPP",
155+
"job_name": "Build Sample for Android with minimal supported editor (6000.0), burst ON, IL2CPP",
156156
"variables": [
157157
{ "key": "BURST_ON_OFF", "value": "on" },
158158
{ "key": "PLATFORM_WIN64_MAC_ANDROID", "value": "android" },
159159
{ "key": "SCRIPTING_BACKEND_IL2CPP_MONO", "value": "il2cpp" },
160-
{ "key": "UNITY_VERSION", "value": "2022.3" } # Minimal supported editor
160+
{ "key": "UNITY_VERSION", "value": "6000.0" } # Minimal supported editor
161161
]
162162
},
163163
{
164-
"job_name": "Build Sample for Android with latest functional editor (6000.2), burst ON, IL2CPP",
164+
"job_name": "Build Sample for Android with latest functional editor (6000.3), burst ON, IL2CPP",
165165
"variables": [
166166
{ "key": "BURST_ON_OFF", "value": "on" },
167167
{ "key": "PLATFORM_WIN64_MAC_ANDROID", "value": "android" },

Tools/scripts/Utils/triggerYamatoJobsForReleasePreparation.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,12 @@ def trigger_automated_builds_job_on_yamato(yamato_api_token, project_id, branch_
7575
7676
build_automation_configs = [
7777
{
78-
"job_name": "Build Sample for Windows with minimal supported editor (2022.3), burst ON, IL2CPP",
78+
"job_name": "Build Sample for Windows with latest supported editor (6000.3), burst ON, IL2CPP",
7979
"variables": [
8080
{ "key": "BURST_ON_OFF", "value": "on" },
8181
{ "key": "PLATFORM_WIN64_MAC_ANDROID", "value": "win64" },
8282
{ "key": "SCRIPTING_BACKEND_IL2CPP_MONO", "value": "il2cpp" },
83-
{ "key": "UNITY_VERSION", "value": "2022.3" }
83+
{ "key": "UNITY_VERSION", "value": "6000.3" }
8484
]
8585
}
8686
]
@@ -125,7 +125,8 @@ def trigger_release_preparation_jobs(config: ReleaseConfig):
125125
try:
126126
revision_sha = get_latest_git_revision(config.release_branch_name)
127127

128-
trigger_wrench_promotion_job_on_yamato(config.yamato_api_token, config.yamato_project_id, config.release_branch_name, revision_sha)
128+
# We don't need to trigger promotion job to run the tests for the release branch since those are being triggered automatically on release/ prefixed branches
129+
#trigger_wrench_promotion_job_on_yamato(config.yamato_api_token, config.yamato_project_id, config.release_branch_name, revision_sha)
129130
trigger_automated_builds_job_on_yamato(config.yamato_api_token, config.yamato_project_id, config.release_branch_name, revision_sha, config.yamato_samples_to_build, config.yamato_build_automation_configs)
130131

131132
except Exception as e:

com.unity.netcode.gameobjects/CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,15 @@ Additional documentation and release notes are available at [Multiplayer Documen
2323

2424
### Fixed
2525

26-
- Fixed `NetworkShow` behavior when it is called twice. (#3867)
26+
- Fixed issue where an attachable could log an error upon being de-spawned during shutdown. (#3895)
2727
- NestedNetworkVariables initialized with no value no longer throw an error. (#3891)
28+
- Fixed `NetworkShow` behavior when it is called twice. (#3867)
2829

2930
### Security
3031

3132

3233
### Obsolete
33-
- `NotListeningException` is now marked as obsolete as it is not used internally anymore. (#3867)
34+
- `NotListeningException` is now marked as obsolete as it is no longer used internally. (#3867)
3435

3536
## [2.10.0] - 2026-03-01
3637

com.unity.netcode.gameobjects/Runtime/Components/Helpers/AttachableBehaviour.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ internal void ForceDetach()
278278
/// <inheritdoc/>
279279
public override void OnNetworkPreDespawn()
280280
{
281-
if (AutoDetach.HasFlag(AutoDetachTypes.OnDespawn))
281+
if (NetworkManager.ShutdownInProgress || AutoDetach.HasFlag(AutoDetachTypes.OnDespawn))
282282
{
283283
ForceDetach();
284284
}
@@ -474,10 +474,11 @@ internal void InternalDetach()
474474
/// </summary>
475475
public void Detach()
476476
{
477-
if (!gameObject)
477+
if (!gameObject || NetworkObject == null || NetworkManager == null || NetworkManager.ShutdownInProgress)
478478
{
479479
return;
480480
}
481+
481482
if (!IsSpawned)
482483
{
483484
NetworkLog.LogError($"[{name}][Detach][Not Spawned] Cannot detach if not spawned!");

com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectNetworkClientOwnedObjectsTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public IEnumerator WhenOwnershipIsChanged_OwnershipValuesUpdateCorrectly()
7575
Assert.IsFalse(serverBehaviour.IsOwnedByServer);
7676
Assert.AreEqual(m_ClientNetworkManagers[0].LocalClientId, serverBehaviour.OwnerClientId);
7777

78-
var clientObject = FindObjects.ByType<NetworkObject>(orderByIdentifier: true).Where((obj) => obj.NetworkManagerOwner == m_ClientNetworkManagers[0]).FirstOrDefault();
78+
var clientObject = m_ClientNetworkManagers[0].SpawnManager.SpawnedObjects.ContainsKey(serverObject.NetworkObjectId) ? m_ClientNetworkManagers[0].SpawnManager.SpawnedObjects[serverObject.NetworkObjectId] : null;
7979

8080
Assert.IsNotNull(clientObject);
8181
Assert.IsTrue(clientObject.IsOwner);

0 commit comments

Comments
 (0)