fix

More PVP fun

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Runtime/Components/Interpolator/BufferedLinearInterpolator.cs

@@ -13,6 +13,9 @@ public abstract class BufferedLinearInterpolator<T> where T : struct
     {
         private const float k_AproximatePrecision = 0.0001f;
 
+        /// <summary>
+        /// Represents a buffered item measurement.
+        /// </summary>
         protected internal struct BufferedItem
         {
             public int ItemId;
@@ -117,7 +120,6 @@ public void Reset(T currentValue)
         private BufferedItem m_LastBufferedItemReceived;
         private int m_NbItemsReceivedThisFrame;
 
-        protected internal T m_CurrentInterpValue;
         private double m_LastMeasurementAddedTime = 0.0f;
         internal bool EndOfBuffer => m_Buffer.Count == 0;
 
@@ -127,17 +129,22 @@ public void Reset(T currentValue)
         /// The current interpolation state
         /// </summary>
         internal CurrentState InterpolateState;
+
+        /// <summary>
+        /// The current buffered items received by the authority.
+        /// </summary>
         protected internal readonly Queue<BufferedItem> m_Buffer = new Queue<BufferedItem>(k_BufferCountLimit);
 
         /// <summary>
         /// Represents the rate of change for the value being interpolated when smooth dampening is enabled.
         /// </summary>
         private T m_RateOfChange;
 
-        private bool m_UseSmoothDamening;
-        protected bool UseSmoothDampening => m_UseSmoothDamening;
-
         private bool m_IsAngularValue;
+
+        /// <summary>
+        /// When true, the value <see cref="T"/> is an angular numeric representation.
+        /// </summary>
         protected bool IsAngularValue => m_IsAngularValue;
 
         /// <summary>
@@ -147,7 +154,6 @@ public void Clear()
         {
             m_Buffer.Clear();
             m_BufferCount = 0;
-            m_CurrentInterpValue = default;
             m_LastMeasurementAddedTime = 0.0;
             InterpolateState.Reset(default);
             m_RateOfChange = default;
@@ -171,8 +177,6 @@ public void ResetTo(T targetValue, double serverTime, bool isAngularValue = fals
             Clear();
             // Set our initial value
             InterpolateState.Reset(targetValue);
-            // TODO: If we get single lerping working, then m_CurrentInterpValue is no longer needed.
-            m_CurrentInterpValue = targetValue;
             m_IsAngularValue = isAngularValue;
 
             // Add the first measurement for our baseline
@@ -416,8 +420,10 @@ protected internal virtual bool IsAproximately(T first, T second, float precisio
         /// <summary>
         /// Converts a value of type <see cref="T"/> from world to local space or vice versa.
         /// </summary>
-        /// <param name="transform">Reference transform</param>
-        /// <param name="inLocalSpace">local or world space (true or false)</param>
+        /// <param name="transform">Reference transform.</param>
+        /// <param name="item">The item to convert.</param>
+        /// <param name="inLocalSpace">local or world space (true or false).</param>
+        /// <returns>The converted value.</returns>
         protected internal virtual T OnConvertTransformSpace(Transform transform, T item, bool inLocalSpace)
         {
             return default;