Merge branch 'develop-2.0.0' into fix/networkshow-client-synchronization-duplicate-players

Author: NoelStephensUnity

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -12,6 +12,8 @@ Additional documentation and release notes are available at [Multiplayer Documen
 
 ### Fixed
 
+- Fixed: Issue where there was a potential for a small memory leak in the `ConnectionApprovedMessage`. (#3486)
+
 ### Changed
 
 ## [2.4.0] - 2025-06-02

com.unity.netcode.gameobjects/Runtime/Messaging/Messages/ConnectionApprovedMessage.cs

@@ -262,6 +262,7 @@ public void Handle(ref NetworkContext context)
                 {
                     NetworkLog.LogWarning($"[Client-{OwnerClientId}] Receiving duplicate connection approved. Client is already connected!");
                 }
+                ConnectedClientIds.Dispose();
                 return;
             }
 
@@ -304,6 +305,9 @@ public void Handle(ref NetworkContext context)
                 }
             }
 
+            // Dispose after it has been used.
+            ConnectedClientIds.Dispose();
+
             // Only if scene management is disabled do we handle NetworkObject synchronization at this point
             if (!networkManager.NetworkConfig.EnableSceneManagement)
             {
@@ -387,7 +391,6 @@ public void Handle(ref NetworkContext context)
                     }
                 }
             }
-            ConnectedClientIds.Dispose();
         }
     }
 }