test

The test that validates the NetworkLog fix.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -1020,6 +1020,14 @@ private void OnTransformParentChanged()
             NetworkManagerCheckForParent();
         }
 
+        /// <summary>
+        /// For testing purposes when you need the singleton to be null
+        /// </summary>
+        internal static void ResetSingleton()
+        {
+            Singleton = null;
+        }
+
         /// <summary>
         /// Set this NetworkManager instance as the static NetworkManager singleton
         /// </summary>

com.unity.netcode.gameobjects/Tests/Runtime/NetworkLogTests.cs

@@ -0,0 +1,47 @@
+using System.Collections;
+using Unity.Netcode.TestHelpers.Runtime;
+using UnityEngine.TestTools;
+
+namespace Unity.Netcode.RuntimeTests
+{
+    /// <summary>
+    /// Validates edge cases with <see cref="NetworkLog"/>
+    /// </summary>
+    internal class NetworkLogTests : NetcodeIntegrationTest
+    {
+        protected override int NumberOfClients => 0;
+        private bool m_ServerStopped;
+
+        /// <summary>
+        /// Validates that if no <see cref="NetworkManager"/> exists,
+        /// you can still use NetworkLog with the caveat when one does
+        /// not exist it will only log locally.
+        /// (is topology agnostic)
+        /// </summary>
+        [UnityTest]
+        public IEnumerator UseNetworkLogWithNoNetworkManager()
+        {
+            m_ServerStopped = false;
+            var authority = GetAuthorityNetworkManager();
+            authority.OnServerStopped += OnServerStopped;
+            authority.Shutdown();
+            yield return WaitForConditionOrTimeOut(()=>  m_ServerStopped);
+            AssertOnTimeout($"Timed out waiting for {nameof(NetworkManager)} to stop!");
+            // Assure it is destroyed.
+            UnityEngine.Object.Destroy(authority);
+            authority = null;
+
+            // Clear out the singleton to assure NetworkLog has no references to a NetworkManager
+            NetworkManager.ResetSingleton();
+
+            // Validate you can use NetworkLog without any NetworkManager instance.
+            NetworkLog.LogInfoServer($"Test a message to the server with no  {nameof(NetworkManager)}.");
+            // No exceptions thrown is considered passing.
+        }
+
+        private void OnServerStopped(bool obj)
+        {
+            m_ServerStopped = true;
+        }
+    }
+}