fix: memory leak without domain reload

NorbertUnity · NorbertUnity · commit 910d6a104bfa · 2025-04-25T10:41:20.000+02:00
playModeStateChanged never gets unsubscribed
diff --git a/com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs b/com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs
@@ -1629,6 +1629,10 @@ private void OnDestroy()
             {
                 Singleton = null;
             }
+
+#if UNITY_EDITOR
+            EditorApplication.playModeStateChanged -= ModeChanged;
+#endif
         }
 
         // Command line options

Original file line number	Diff line number	Diff line change
`@@ -1629,6 +1629,10 @@ private void OnDestroy()`
`1629`	`1629`	`{`
`1630`	`1630`	`Singleton = null;`
`1631`	`1631`	`}`
	`1632`	`+`
	`1633`	`+#if UNITY_EDITOR`
	`1634`	`+ EditorApplication.playModeStateChanged -= ModeChanged;`
	`1635`	`+#endif`
`1632`	`1636`	`}`
`1633`	`1637`
`1634`	`1638`	`// Command line options`