Use cached NetworkManager in NetworkAnimator

Author: noellie-velez

com.unity.netcode.gameobjects/Runtime/Components/NetworkAnimator.cs

@@ -194,8 +194,7 @@ internal void DeregisterUpdate()
         internal NetworkAnimatorStateChangeHandler(NetworkAnimator networkAnimator)
         {
             m_NetworkAnimator = networkAnimator;
-            // TODO can we use m_LocalNetworkManager here or other cached var?
-            m_IsServer = networkAnimator.NetworkManager.IsServer;
+            m_IsServer = networkAnimator.LocalNetworkManager.IsServer;
             NetworkUpdateLoop.RegisterNetworkUpdate(this, NetworkUpdateStage.PreUpdate);
         }
     }
@@ -280,7 +279,7 @@ public Animator Animator
         private Dictionary<int, Dictionary<int, TransitionStateinfo>> m_DestinationStateToTransitioninfo = new Dictionary<int, Dictionary<int, TransitionStateinfo>>();
 
         // Named differently to avoid serialization conflicts with NetworkBehaviour
-        private NetworkManager m_LocalNetworkManager;
+        internal NetworkManager LocalNetworkManager;
 
         internal bool DistributedAuthorityMode;
 
@@ -919,8 +918,8 @@ internal AnimationMessage GetAnimationMessage()
         internal override void InternalOnNetworkPreSpawn(ref NetworkManager networkManager)
         {
             // Save internal state references
-            m_LocalNetworkManager = networkManager;
-            DistributedAuthorityMode = m_LocalNetworkManager.DistributedAuthorityMode;
+            LocalNetworkManager = networkManager;
+            DistributedAuthorityMode = LocalNetworkManager.DistributedAuthorityMode;
         }
 
         /// <inheritdoc/>
@@ -1180,7 +1179,7 @@ internal void CheckForAnimatorChanges()
 
             if (m_Animator.runtimeAnimatorController == null)
             {
-                if (m_LocalNetworkManager.LogLevel == LogLevel.Developer)
+                if (LocalNetworkManager.LogLevel == LogLevel.Developer)
                 {
                     Debug.LogError($"[{GetType().Name}] Could not find an assigned {nameof(RuntimeAnimatorController)}! Cannot check {nameof(Animator)} for changes in state!");
                 }
@@ -1215,9 +1214,9 @@ internal void CheckForAnimatorChanges()
                 {
                     // Just notify all remote clients and not the local server
                     m_TargetGroup.Clear();
-                    foreach (var clientId in m_LocalNetworkManager.ConnectionManager.ConnectedClientIds)
+                    foreach (var clientId in LocalNetworkManager.ConnectionManager.ConnectedClientIds)
                     {
-                        if (clientId == m_LocalNetworkManager.LocalClientId || !NetworkObject.Observers.Contains(clientId))
+                        if (clientId == LocalNetworkManager.LocalClientId || !NetworkObject.Observers.Contains(clientId))
                         {
                             continue;
                         }
@@ -1245,7 +1244,7 @@ private void SendParametersUpdate(RpcParams rpcParams = default, bool sendDirect
                 }
                 else
                 {
-                    Debug.LogError($"[{name}][Client-{m_LocalNetworkManager.LocalClientId}] Attempting to send parameter updates but not the owner!");
+                    Debug.LogError($"[{name}][Client-{LocalNetworkManager.LocalClientId}] Attempting to send parameter updates but not the owner!");
                 }
             }
             else
@@ -1495,12 +1494,12 @@ internal void UpdateAnimationState(AnimationState animationState)
                             // Cross fade from the current to the destination state for the transitions duration while starting at the server's current normalized time of the transition
                             m_Animator.CrossFade(transitionStateInfo.DestinationState, transitionStateInfo.TransitionDuration, transitionStateInfo.Layer, 0.0f, animationState.NormalizedTime);
                         }
-                        else if (m_LocalNetworkManager.LogLevel == LogLevel.Developer)
+                        else if (LocalNetworkManager.LogLevel == LogLevel.Developer)
                         {
                             NetworkLog.LogWarning($"Current State Hash ({currentState.fullPathHash}) != AnimationState.StateHash ({animationState.StateHash})");
                         }
                     }
-                    else if (m_LocalNetworkManager.LogLevel == LogLevel.Developer)
+                    else if (LocalNetworkManager.LogLevel == LogLevel.Developer)
                     {
                         NetworkLog.LogError($"[DestinationState To Transition Info] Layer ({animationState.Layer}) sub-table does not contain destination state ({animationState.DestinationStateHash})!");
                     }
@@ -1543,7 +1542,7 @@ private unsafe void SendServerParametersUpdateRpc(ParametersUpdateMessage parame
                     return;
                 }
                 UpdateParameters(ref parametersUpdate);
-                var connectedClientIds = m_LocalNetworkManager.ConnectionManager.ConnectedClientIds;
+                var connectedClientIds = LocalNetworkManager.ConnectionManager.ConnectedClientIds;
                 if (connectedClientIds.Count <= (IsHost ? 2 : 1))
                 {
                     return;
@@ -1609,7 +1608,7 @@ private void SendServerAnimStateRpc(AnimationMessage animationMessage, RpcParams
                     UpdateAnimationState(animationState);
                 }
 
-                var connectedClientIds = m_LocalNetworkManager.ConnectionManager.ConnectedClientIds;
+                var connectedClientIds = LocalNetworkManager.ConnectionManager.ConnectedClientIds;
                 if (connectedClientIds.Count <= (IsHost ? 2 : 1))
                 {
                     return;
@@ -1656,7 +1655,7 @@ private void ProcessAnimStates(AnimationMessage animationMessage)
         {
             if (HasAuthority)
             {
-                if (m_LocalNetworkManager.LogLevel == LogLevel.Developer)
+                if (LocalNetworkManager.LogLevel == LogLevel.Developer)
                 {
                     var hostOrOwner = DistributedAuthorityMode ? "Owner" : "Host";
                     var clientServerOrDAMode = DistributedAuthorityMode ? "distributed authority" : "client-server";
@@ -1681,7 +1680,7 @@ internal void SendServerAnimTriggerRpc(AnimationTriggerMessage animationTriggerM
             // Ignore if a non-owner sent this.
             if (rpcParams.Receive.SenderClientId != OwnerClientId)
             {
-                if (m_LocalNetworkManager.LogLevel == LogLevel.Developer)
+                if (LocalNetworkManager.LogLevel == LogLevel.Developer)
                 {
                     NetworkLog.LogWarning($"[Owner Authoritative] Detected the a non-authoritative client is sending the server animation trigger updates. If you recently changed ownership of the {name} object, then this could be the reason.");
                 }
@@ -1691,7 +1690,7 @@ internal void SendServerAnimTriggerRpc(AnimationTriggerMessage animationTriggerM
             // set the trigger locally on the server
             InternalSetTrigger(animationTriggerMessage.Hash, animationTriggerMessage.IsTriggerSet);
 
-            var connectedClientIds = m_LocalNetworkManager.ConnectionManager.ConnectedClientIds;
+            var connectedClientIds = LocalNetworkManager.ConnectionManager.ConnectedClientIds;
 
             m_TargetGroup.Clear();
             foreach (var clientId in connectedClientIds)