fix

Fixing issue where we need to reset the OwnerId and PreviousOwnerId after running through NetworkBehaviourUpdate to assure the values are properly set when there are no dirty objects to reset.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs

@@ -108,13 +108,6 @@ internal void NetworkBehaviourUpdate(bool forceSend = false)
                 foreach (var dirtyobj in m_DirtyNetworkObjects)
                 {
                     dirtyobj.PostNetworkVariableWrite(forceSend);
-                    // If we are force sending, then we are changing ownership and making sure that we
-                    // do a full synchronization of NetworkVariables.
-                    if (forceSend)
-                    {
-                        // Once done processing, we set the previous owner id to the current owner id
-                        dirtyobj.PreviousOwnerId = dirtyobj.OwnerClientId;
-                    }
                 }
                 m_DirtyNetworkObjects.Clear();
             }

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -2591,13 +2591,10 @@ internal void SynchronizeOwnerNetworkVariables(ulong originalOwnerId, ulong orig
             // Force send a state update for all owner read NetworkVariables
             // and any currently dirty owner write NetworkVariables.
             NetworkManager.BehaviourUpdater.NetworkBehaviourUpdate(true);
-            // Now set the new owner identifier back to its original new owner identifier
+            // Now set the new owner identifier back to its original new owner identifier and
+            // set the previous owner back to the original owner identifier.
             OwnerClientId = currentOwnerId;
-            // The previous owner should now be the originalOwnerId at this point.
-            if (PreviousOwnerId != originalOwnerId)
-            {
-                Debug.LogError($"[NetworkVaraible][Full Synchronization] Expected {nameof(PreviousOwnerId)} ({PreviousOwnerId}) to be the original owner id ({originalOwnerId})!");
-            }
+            PreviousOwnerId = originalOwnerId;
         }
 
         // NGO currently guarantees that the client will receive spawn data for all objects in one network tick.

com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs

@@ -558,9 +558,9 @@ internal void ChangeOwnership(NetworkObject networkObject, ulong clientId, bool
             // Always notify locally on the server when a new owner is assigned
             networkObject.InvokeBehaviourOnGainedOwnership();
 
-            if (networkObject.PreviousOwnerId == NetworkManager.LocalClientId)
+            // If we are the original owner, then we want to synchronize owner read & write NetworkVariables.
+            if (originalOwner == NetworkManager.LocalClientId)
             {
-                // Mark any owner read variables as dirty
                 networkObject.SynchronizeOwnerNetworkVariables(originalOwner, originalPreviousOwnerId);
             }