Skip to content

Commit f10b0c3

Browse files
NoelStephensUnityNoelStephensUnity
committed
fix
Marking all of the fields that Roslyn is complaining about as internal.
1 parent 1b1fea8 commit f10b0c3

15 files changed

+53
-53
lines changed

‎com.unity.netcode.gameobjects/Tests/Runtime/Components/NetworkVariableTestComponent.cs‎

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -208,31 +208,31 @@ internal class NetworkVariableTestComponent : NetworkBehaviour
208208
private NetworkVariable<ManagedNetworkSerializableType> m_NetworkVariableManaged = new NetworkVariable<ManagedNetworkSerializableType>();
209209

210210

211-
public NetworkVariableHelper<bool> Bool_Var;
212-
public NetworkVariableHelper<byte> Byte_Var;
213-
public NetworkVariableHelper<Color> Color_Var;
214-
public NetworkVariableHelper<Color32> Color32_Var;
215-
public NetworkVariableHelper<double> Double_Var;
216-
public NetworkVariableHelper<float> Float_Var;
217-
public NetworkVariableHelper<int> Int_Var;
218-
public NetworkVariableHelper<long> Long_Var;
219-
public NetworkVariableHelper<sbyte> Sbyte_Var;
220-
public NetworkVariableHelper<Quaternion> Quaternion_Var;
221-
public NetworkVariableHelper<Pose> Pose_Var;
222-
public NetworkVariableHelper<short> Short_Var;
223-
public NetworkVariableHelper<Vector4> Vector4_Var;
224-
public NetworkVariableHelper<Vector3> Vector3_Var;
225-
public NetworkVariableHelper<Vector2> Vector2_Var;
226-
public NetworkVariableHelper<Ray> Ray_Var;
227-
public NetworkVariableHelper<ulong> Ulong_Var;
228-
public NetworkVariableHelper<uint> Uint_Var;
229-
public NetworkVariableHelper<ushort> Ushort_Var;
230-
public NetworkVariableHelper<FixedString32Bytes> FixedString32_Var;
231-
public NetworkVariableHelper<FixedString64Bytes> FixedString64_Var;
232-
public NetworkVariableHelper<FixedString128Bytes> FixedString128_Var;
233-
public NetworkVariableHelper<FixedString512Bytes> FixedString512_Var;
234-
public NetworkVariableHelper<FixedString4096Bytes> FixedString4096_Var;
235-
public NetworkVariableHelper<ManagedNetworkSerializableType> Managed_Var;
211+
internal NetworkVariableHelper<bool> Bool_Var;
212+
internal NetworkVariableHelper<byte> Byte_Var;
213+
internal NetworkVariableHelper<Color> Color_Var;
214+
internal NetworkVariableHelper<Color32> Color32_Var;
215+
internal NetworkVariableHelper<double> Double_Var;
216+
internal NetworkVariableHelper<float> Float_Var;
217+
internal NetworkVariableHelper<int> Int_Var;
218+
internal NetworkVariableHelper<long> Long_Var;
219+
internal NetworkVariableHelper<sbyte> Sbyte_Var;
220+
internal NetworkVariableHelper<Quaternion> Quaternion_Var;
221+
internal NetworkVariableHelper<Pose> Pose_Var;
222+
internal NetworkVariableHelper<short> Short_Var;
223+
internal NetworkVariableHelper<Vector4> Vector4_Var;
224+
internal NetworkVariableHelper<Vector3> Vector3_Var;
225+
internal NetworkVariableHelper<Vector2> Vector2_Var;
226+
internal NetworkVariableHelper<Ray> Ray_Var;
227+
internal NetworkVariableHelper<ulong> Ulong_Var;
228+
internal NetworkVariableHelper<uint> Uint_Var;
229+
internal NetworkVariableHelper<ushort> Ushort_Var;
230+
internal NetworkVariableHelper<FixedString32Bytes> FixedString32_Var;
231+
internal NetworkVariableHelper<FixedString64Bytes> FixedString64_Var;
232+
internal NetworkVariableHelper<FixedString128Bytes> FixedString128_Var;
233+
internal NetworkVariableHelper<FixedString512Bytes> FixedString512_Var;
234+
internal NetworkVariableHelper<FixedString4096Bytes> FixedString4096_Var;
235+
internal NetworkVariableHelper<ManagedNetworkSerializableType> Managed_Var;
236236

237237

238238
public bool EnableTesting;

‎com.unity.netcode.gameobjects/Tests/Runtime/DistributedAuthority/DistributedAuthorityCodecTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ private static ushort GetPortToBind()
7474

7575
internal class TestNetworkComponent : NetworkBehaviour
7676
{
77-
public NetworkList<int> MyNetworkList = new NetworkList<int>(new List<int> { 1, 2, 3 });
77+
internal NetworkList<int> MyNetworkList = new NetworkList<int>(new List<int> { 1, 2, 3 });
7878
public NetworkVariable<int> MyNetworkVar = new NetworkVariable<int>(3);
7979

8080
[Rpc(SendTo.Authority)]

‎com.unity.netcode.gameobjects/Tests/Runtime/HiddenVariableTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ internal class HiddenVariableObject : NetworkBehaviour
1616
public static List<NetworkObject> ClientInstancesSpawned = new List<NetworkObject>();
1717

1818
public NetworkVariable<int> MyNetworkVariable = new NetworkVariable<int>();
19-
public NetworkList<int> MyNetworkList = new NetworkList<int>();
19+
internal NetworkList<int> MyNetworkList = new NetworkList<int>();
2020

2121
public static Dictionary<ulong, int> ValueOnClient = new Dictionary<ulong, int>();
2222
public static int ExpectedSize = 0;

‎com.unity.netcode.gameobjects/Tests/Runtime/ListChangedTest.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ internal class ListChangedObject : NetworkBehaviour
1717
public int ExpectedValue = 0;
1818
public bool AddDone = false;
1919

20-
public NetworkList<int> MyNetworkList = new NetworkList<int>();
20+
internal NetworkList<int> MyNetworkList = new NetworkList<int>();
2121

2222
public override void OnNetworkSpawn()
2323
{

‎com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectSynchronizationTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ public static void ResetSpawnCount()
399399
private const uint k_MaxDataBlocks = 64;
400400

401401
// Add various types of NetworkVariables
402-
public NetworkList<ulong> NetworkVariableData1;
402+
internal NetworkList<ulong> NetworkVariableData1;
403403
public NetworkVariable<int> NetworkVariableData2;
404404
public NetworkVariable<long> NetworkVariableData3;
405405
public NetworkVariable<byte> NetworkVariableData4;
@@ -665,7 +665,7 @@ protected override void OnSynchronize<T>(ref BufferSerializer<T> serializer)
665665

666666
internal class NetworkBehaviourOnSynchronizeComponent : NetworkBehaviour
667667
{
668-
public SomeCustomSerializationData CustomSerializationData = new SomeCustomSerializationData();
668+
internal SomeCustomSerializationData CustomSerializationData = new SomeCustomSerializationData();
669669

670670
internal struct SomeCustomSerializationData : INetworkSerializable
671671
{

‎com.unity.netcode.gameobjects/Tests/Runtime/NetworkShowHideTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ public override void OnNetworkDespawn()
6565
}
6666

6767
public NetworkVariable<int> MyNetworkVariable = new NetworkVariable<int>();
68-
public NetworkList<int> MyListSetOnSpawn = new NetworkList<int>();
68+
internal NetworkList<int> MyListSetOnSpawn = new NetworkList<int>();
6969
public NetworkVariable<int> MyOwnerReadNetworkVariable = new NetworkVariable<int>(readPerm: NetworkVariableReadPermission.Owner);
70-
public NetworkList<int> MyList = new NetworkList<int>();
70+
internal NetworkList<int> MyList = new NetworkList<int>();
7171
public static NetworkManager NetworkManagerOfInterest;
7272

7373
internal static int GainOwnershipCount = 0;

‎com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformBase.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -754,7 +754,7 @@ internal class NetworkTransformTestComponent : NetworkTransform
754754
public bool ServerAuthority;
755755
public bool ReadyToReceivePositionUpdate = false;
756756

757-
public NetworkTransformState AuthorityLastSentState;
757+
internal NetworkTransformState AuthorityLastSentState;
758758
public bool StatePushed { get; internal set; }
759759

760760
public delegate void AuthorityPushedTransformStateDelegateHandler(ref NetworkTransformState networkTransformState);

‎com.unity.netcode.gameobjects/Tests/Runtime/NetworkUpdateLoopTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,8 +290,8 @@ private struct MonoBehaviourCallbacks
290290

291291
private class MyGameScript : MonoBehaviour, INetworkUpdateSystem
292292
{
293-
public NetworkUpdateCallbacks UpdateCallbacks;
294-
public MonoBehaviourCallbacks BehaviourCallbacks;
293+
internal NetworkUpdateCallbacks UpdateCallbacks;
294+
internal MonoBehaviourCallbacks BehaviourCallbacks;
295295

296296
private void Awake()
297297
{

‎com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVarBufferCopyTest.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public DummyNetVar(
7878
internal class DummyNetBehaviour : NetworkBehaviour
7979
{
8080
public static bool DistributedAuthority;
81-
public DummyNetVar NetVar;
81+
internal DummyNetVar NetVar;
8282

8383
private void Awake()
8484
{

‎com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableCollectionsTests.cs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1222,7 +1222,7 @@ public static void ResetState()
12221222
public NetworkVariable<HashSet<int>> ListCollectionServer = new NetworkVariable<HashSet<int>>(new HashSet<int>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Server);
12231223
public NetworkVariable<HashSet<int>> ListCollectionOwner = new NetworkVariable<HashSet<int>>(new HashSet<int>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Owner);
12241224
// This tracks what has changed per instance which is used to compare to all other instances
1225-
public Dictionary<Targets, Dictionary<DeltaTypes, HashSet<int>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, HashSet<int>>>();
1225+
internal Dictionary<Targets, Dictionary<DeltaTypes, HashSet<int>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, HashSet<int>>>();
12261226

12271227
public bool ValidateInstances()
12281228
{
@@ -1471,7 +1471,7 @@ public static void ResetState()
14711471
public NetworkVariable<Dictionary<int, Dictionary<int, SerializableObject>>> ListCollectionServer = new NetworkVariable<Dictionary<int, Dictionary<int, SerializableObject>>>(new Dictionary<int, Dictionary<int, SerializableObject>>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Server);
14721472
public NetworkVariable<Dictionary<int, Dictionary<int, SerializableObject>>> ListCollectionOwner = new NetworkVariable<Dictionary<int, Dictionary<int, SerializableObject>>>(new Dictionary<int, Dictionary<int, SerializableObject>>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Owner);
14731473
// This tracks what has changed per instance which is used to compare to all other instances
1474-
public Dictionary<Targets, Dictionary<DeltaTypes, Dictionary<int, Dictionary<int, SerializableObject>>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, Dictionary<int, Dictionary<int, SerializableObject>>>>();
1474+
internal Dictionary<Targets, Dictionary<DeltaTypes, Dictionary<int, Dictionary<int, SerializableObject>>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, Dictionary<int, Dictionary<int, SerializableObject>>>>();
14751475

14761476
private bool CompareDictionaries(ulong clientId, Dictionary<int, SerializableObject> first, Dictionary<int, SerializableObject> second)
14771477
{
@@ -1778,7 +1778,7 @@ public static void ResetState()
17781778
public NetworkVariable<Dictionary<int, SerializableObject>> ListCollectionServer = new NetworkVariable<Dictionary<int, SerializableObject>>(new Dictionary<int, SerializableObject>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Server);
17791779
public NetworkVariable<Dictionary<int, SerializableObject>> ListCollectionOwner = new NetworkVariable<Dictionary<int, SerializableObject>>(new Dictionary<int, SerializableObject>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Owner);
17801780
// This tracks what has changed per instance which is used to compare to all other instances
1781-
public Dictionary<Targets, Dictionary<DeltaTypes, Dictionary<int, SerializableObject>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, Dictionary<int, SerializableObject>>>();
1781+
internal Dictionary<Targets, Dictionary<DeltaTypes, Dictionary<int, SerializableObject>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, Dictionary<int, SerializableObject>>>();
17821782

17831783
private bool CompareDictionaries(ulong clientId, Dictionary<int, SerializableObject> first, Dictionary<int, SerializableObject> second)
17841784
{
@@ -2145,7 +2145,7 @@ public static void ResetState()
21452145
public NetworkVariable<List<List<SerializableObject>>> ListCollectionServer = new NetworkVariable<List<List<SerializableObject>>>(new List<List<SerializableObject>>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Server);
21462146
public NetworkVariable<List<List<SerializableObject>>> ListCollectionOwner = new NetworkVariable<List<List<SerializableObject>>>(new List<List<SerializableObject>>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Owner);
21472147
// This tracks what has changed per instance which is used to compare to all other instances
2148-
public Dictionary<Targets, Dictionary<DeltaTypes, List<List<SerializableObject>>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, List<List<SerializableObject>>>>();
2148+
internal Dictionary<Targets, Dictionary<DeltaTypes, List<List<SerializableObject>>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, List<List<SerializableObject>>>>();
21492149

21502150
public bool ValidateInstances()
21512151
{
@@ -2444,7 +2444,7 @@ public static void ResetState()
24442444
public NetworkVariable<List<SerializableObject>> ListCollectionServer = new NetworkVariable<List<SerializableObject>>(new List<SerializableObject>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Server);
24452445
public NetworkVariable<List<SerializableObject>> ListCollectionOwner = new NetworkVariable<List<SerializableObject>>(new List<SerializableObject>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Owner);
24462446
// This tracks what has changed per instance which is used to compare to all other instances
2447-
public Dictionary<Targets, Dictionary<DeltaTypes, List<SerializableObject>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, List<SerializableObject>>>();
2447+
internal Dictionary<Targets, Dictionary<DeltaTypes, List<SerializableObject>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, List<SerializableObject>>>();
24482448

24492449
public bool ValidateInstances()
24502450
{
@@ -2709,7 +2709,7 @@ public static void ResetState()
27092709
public NetworkVariable<List<List<int>>> ListCollectionServer = new NetworkVariable<List<List<int>>>(new List<List<int>>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Server);
27102710
public NetworkVariable<List<List<int>>> ListCollectionOwner = new NetworkVariable<List<List<int>>>(new List<List<int>>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Owner);
27112711
// This tracks what has changed per instance which is used to compare to all other instances
2712-
public Dictionary<Targets, Dictionary<DeltaTypes, List<List<int>>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, List<List<int>>>>();
2712+
internal Dictionary<Targets, Dictionary<DeltaTypes, List<List<int>>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, List<List<int>>>>();
27132713

27142714
public bool ValidateInstances()
27152715
{
@@ -3013,7 +3013,7 @@ public static void ResetState()
30133013
public NetworkVariable<List<int>> ListCollectionServer = new NetworkVariable<List<int>>(new List<int>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Server);
30143014
public NetworkVariable<List<int>> ListCollectionOwner = new NetworkVariable<List<int>>(new List<int>(), NetworkVariableReadPermission.Everyone, NetworkVariableWritePermission.Owner);
30153015
// This tracks what has changed per instance which is used to compare to all other instances
3016-
public Dictionary<Targets, Dictionary<DeltaTypes, List<int>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, List<int>>>();
3016+
internal Dictionary<Targets, Dictionary<DeltaTypes, List<int>>> NetworkVariableChanges = new Dictionary<Targets, Dictionary<DeltaTypes, List<int>>>();
30173017

30183018
public bool ValidateInstances()
30193019
{

0 commit comments

Comments
 (0)