fix: [Up-port] Avoid throwing exception when using NetworkList without a NetworkManager#3503
Closed
EmandM wants to merge 4 commits intodevelop-2.0.0from
Closed
fix: [Up-port] Avoid throwing exception when using NetworkList without a NetworkManager#3503EmandM wants to merge 4 commits intodevelop-2.0.0from
EmandM wants to merge 4 commits intodevelop-2.0.0from
Conversation
EmandM
changed the title
Some missed parenthesis addition and removal.
Member
|
This PR has migrated to #3504 to land with v2.4.2. |
Member
|
Does it mean that you want to add it to develop-2.0.0 when merging 2.4.2 back to it? Or was it included somehow else |
Member
|
Just a follow up that this was merged in |
EmandM
added a commit
that referenced
this pull request
Jun 24, 2025
…kManager (#3502) <!-- Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. --> <!-- Add short version of the JIRA ticket to the PR title (e.g. "feat: new shiny feature [MTT-123]") --> Continues #2540 Fixes #2539 ## Changelog - Added: `LocalClientCannotWrite` function to co-locate the shared functionality - Fixed: Ensure that the `NetworkManager` exists before attempting to access the `LocalClientId` ## Testing and Documentation - No tests have been added. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> ## Backport <!-- If this is a backport: - Add the following to the PR title: "\[Backport\] ..." . - Link to the original PR. If this needs a backport - state this here If a backport is not needed please provide the reason why. If the "Backports" section is not present it will lead to a CI test failure. --> Up-ported in #3503 --------- Co-authored-by: PitouGames <pitou.games@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up-port of #3502
Fixes #2539
Changelog
LocalClientCannotWritefunction to co-locate the shared functionalityNetworkManagerexists before attempting to access theLocalClientIdTesting and Documentation
Backport
Backported in #3502