Skip to content

ci: Turn off title validation for single commit PRs#3313

Merged
EmandM merged 3 commits intodevelopfrom
ci/turn-off-single-commit-pr-validation
Feb 21, 2025
Merged

ci: Turn off title validation for single commit PRs#3313
EmandM merged 3 commits intodevelopfrom
ci/turn-off-single-commit-pr-validation

Conversation

@EmandM
Copy link
Copy Markdown
Member

@EmandM EmandM commented Feb 20, 2025

When the semantic commit action was added into the branch, the default squash commit for a pr with only a single commit was the commit name and not the PR title. Since then, Github has added a feature to allow configuration of the default and we have that setting set in our repo.

This PR turns off the validation of commits as the check is not valid anymore.

Copy link
Copy Markdown
Member

@michalChrobot michalChrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 2.X PR #3314 you also modified
uses: amannn/action-semantic-pull-request@40166f00814508ec3201fc8595b393d451c8cd80
to
uses: amannn/action-semantic-pull-request@v5

should it be also the case here?

@EmandM
Copy link
Copy Markdown
Member Author

EmandM commented Feb 21, 2025

In 2.X PR #3314 you also modified uses: amannn/action-semantic-pull-request@40166f00814508ec3201fc8595b393d451c8cd80 to uses: amannn/action-semantic-pull-request@v5

should it be also the case here?

Yes! Thanks for the catch

@EmandM EmandM enabled auto-merge (squash) February 21, 2025 15:17
@EmandM EmandM merged commit 991e59c into develop Feb 21, 2025
40 checks passed
@EmandM EmandM deleted the ci/turn-off-single-commit-pr-validation branch February 21, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants