Skip to content

ci: [2.X] Turn off title validation for single commit PRs#3314

Merged
EmandM merged 3 commits intodevelop-2.0.0from
ci/turn-off-single-commit-validation-2.x
Feb 21, 2025
Merged

ci: [2.X] Turn off title validation for single commit PRs#3314
EmandM merged 3 commits intodevelop-2.0.0from
ci/turn-off-single-commit-validation-2.x

Conversation

@EmandM
Copy link
Copy Markdown
Member

@EmandM EmandM commented Feb 20, 2025

2.x

When the semantic commit action was added into the branch, the default squash commit for a pr with only a single commit was the commit name and not the PR title. Since then, Github has added a feature to allow configuration of the default and we have that setting set in our repo.

This PR turns off the validation of commits as the check is not valid anymore.

Copy link
Copy Markdown
Member

@michalChrobot michalChrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, I was starting to get confused by this check failing when PR had only 1 commit

@EmandM EmandM enabled auto-merge (squash) February 21, 2025 15:16
@EmandM EmandM merged commit fc03f94 into develop-2.0.0 Feb 21, 2025
27 checks passed
@EmandM EmandM deleted the ci/turn-off-single-commit-validation-2.x branch February 21, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants