fix: networktransform double lerp (MTTB-539) by NoelStephensUnity · Pull Request #3337 · Unity-Technologies/com.unity.netcode.gameobjects

NoelStephensUnity · 2025-03-05T01:16:49Z

This PR fixes the issue with double lerping by providing two types of interpolators to select from while also exposing the MaximumInterpolationTime for each respective interpolator type. Smooth Dampening is added as an alternative to using lerp for each respective interpolator (position, rotation, and scale).

This PR includes a few new additions:

Additional updates to the inspector view which allows for interpolator type selection and if available additional properties associated with the interpolator.
A new NetworkTimeSystem.TickLatency property that provides the average latency of a client.
An new NetworkTime.FixedDeltaTimeAsDouble property that returns a double version of the NetworkTime.FixedDeltaTime.

This PR also starts the deprecation process for BufferedLinearInterpolator<T>.Update(float deltaTime, NetworkTime serverTime) as this method is only for internal testing purposes.

MTTB-539
MTT-11338 -- Fixing disabled tests

fix: #3112
close: #3112

Changelog

Added: Interpolator types as an inspector view selection for position, rotation, and scale.
Added: A new smooth dampening interpolator type that provides a nice balance between precision and smoothing results.
Added: NetworkTimeSystem.TickLatency property that provides the average latency of a client.
Fixed: Issue where the MaximumInterpolationTime could not be modified from within the inspector view or runtime.
Changed: BufferedLinearInterpolator<T>.Update(float deltaTime, NetworkTime serverTime) as being deprecated since this method is only used for internal testing purposes.

Testing and Documentation

Includes integration test updates:
- InterpolatorTests was updated to changes and two disabled tests were refactored and re-enabled.
- NetworkTransformGeneral includes additional TestFixture passes using Smooth Dampening.
- NetworktTransformTests includes additional TestFixture passes using Smooth Dampening.
- NestedNetworkTransformTests includes additional TestFixture passes using Smooth Dampening.
Includes updates and additions to public documentation (PR-1443)

Some additional updates... still having a hard time getting a single lerp pass without some form of slight jitter. This includes a temporary 2nd pass lerp that still allows for the buffered item value to be completely reached.

Simplifying the new direction and getting all tests to pass. (still needs a smoother transition between buffered items when not finished interpolating from a previous one)

adding some needed comments

Still work in progress. Needs some clean up, but it is looking promising.

The base.OnUpdate is not needed here.

WIP: Smooth dampening seems to be working better than any interpolation approach. Still have a minor timing issue, but I believe can be solved....much closer to a more resilient "interpolator".

Time systems related updates

NetworkTransform and BufferedLinearInterpolator related updates.

Minor fixes for recent changes.

some clean up from wip.

…TB-539

Fixing PVP issues.

Adding XML API documentation to some new NetworkTransform properties.

More PVP fun

More and more PVP fun.

Missed two PVP issues.

Adding Lerp and SmoothDampening to TestFixutres.

Putting some things back and realized I should adhere to the original buffered linear interpolator logic/pattern when using Lerp for interpolation to assure there is no impact on users with this update.

Made an adjustment to the InterpolatorTests.TestUpdatingInterpolatorWithNoData,. Also fixed the two tests that were disabled due to no extrapolation.

Minor fix for an issue when dividing up the smooth damp and lerp buffer consumption.

Made some more adjustments as well as added a predicted smooth dampened value to help with smoothing and to get closer to the target value on the non-authority side. Updated the Quaternion's Approximation to use the dot product instead.

Fixing a bug with one of the tests (evidently was not caught using the previous BLI)

Some fixes for the one test that was failing and more TestFixture additions.

Not sure why these two SetState lerp interpolation tests are having issues as it passes in the editor but fails at runtime... most likely a timing related issue.

Clearing out the 2nd rate of change. Adding delay for the end of the last test in NetworkTransformGeneral.

Seeing if this fixes the issue.

Minor adjustment to smooth dampening.

adding xml api documentation, tooltips, and some editor adjustments.

removing white space

Adding updates to resolve PVP issues for NetworkTransform.

Fixing the remainder of the PVP issues within the components area.

Fixing minor text issues with the newly added XML API documentation.

Putting back the T Update(float deltaTime, NetworkTime serverTime) method and marking it as being deprectated.

Adding a smooth dampening pass to the NestedNetworkTransformTests.

adding change log entries

…TB-539

Adding additional comment on the max delta time calculation.

…ithub.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networktransform-double-lerp-MTTB-539

Fixing some xml api text issues. Making sure we are clearing the interpolator when reaching the maximum boundary.

Adding indentions to the new NetworkTransform inspector view properties grouping.

…TB-539

Moving the property field draw method into the NetcodeEditorBase class in case we wanted to expose it at a later date and/or want to use it for another I-view control.

…ithub.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networktransform-double-lerp-MTTB-539

Adding final touches to the UI updates for the NetworkTransformEditor. Also did a PVP pass for all of the editor related classes.

Fixing some access permissions and sorting through what we are ready to release as a public API.

Some more adjustments to permissions and some final clean up of BufferedLinearInterpolator<T>

…TB-539

NoelStephensUnity added 28 commits February 26, 2025 17:03

update

6eadea1

Some additional updates... still having a hard time getting a single lerp pass without some form of slight jitter. This includes a temporary 2nd pass lerp that still allows for the buffered item value to be completely reached.

update

861dbf1

Simplifying the new direction and getting all tests to pass. (still needs a smoother transition between buffered items when not finished interpolating from a previous one)

style

d5dfc63

adding some needed comments

update

45ed0e1

Still work in progress. Needs some clean up, but it is looking promising.

update

2e40494

The base.OnUpdate is not needed here.

update

b784e14

WIP: Smooth dampening seems to be working better than any interpolation approach. Still have a minor timing issue, but I believe can be solved....much closer to a more resilient "interpolator".

update

08f261c

Time systems related updates

update

4ce6c50

NetworkTransform and BufferedLinearInterpolator related updates.

update

4d691dc

Minor fixes for recent changes.

update

a8a51e2

some clean up from wip.

Merge branch 'develop-2.0.0' into fix/networktransform-double-lerp-MT…

36ed15d

…TB-539

fix

de3094f

Fixing PVP issues.

update

15c8e59

Adding XML API documentation to some new NetworkTransform properties.

fix

283ab9f

More PVP fun

fix

e1f6763

More and more PVP fun.

fix

7b770a4

Missed two PVP issues.

test

6562b90

Adding Lerp and SmoothDampening to TestFixutres.

fix

1cf4f3d

Putting some things back and realized I should adhere to the original buffered linear interpolator logic/pattern when using Lerp for interpolation to assure there is no impact on users with this update.

test

ccd5026

Made an adjustment to the InterpolatorTests.TestUpdatingInterpolatorWithNoData,. Also fixed the two tests that were disabled due to no extrapolation.

fix

f3d564e

Minor fix for an issue when dividing up the smooth damp and lerp buffer consumption.

update

877f4cc

Made some more adjustments as well as added a predicted smooth dampened value to help with smoothing and to get closer to the target value on the non-authority side. Updated the Quaternion's Approximation to use the dot product instead.

test

69480f0

Fixing a bug with one of the tests (evidently was not caught using the previous BLI)

update

d7f14dc

Some fixes for the one test that was failing and more TestFixture additions.

test

7d02134

Not sure why these two SetState lerp interpolation tests are having issues as it passes in the editor but fails at runtime... most likely a timing related issue.

test and update

fc9ee50

Clearing out the 2nd rate of change. Adding delay for the end of the last test in NetworkTransformGeneral.

Test

a5d9bf8

Seeing if this fixes the issue.

update

e5dc365

Minor adjustment to smooth dampening.

update

d917530

adding xml api documentation, tooltips, and some editor adjustments.

NoelStephensUnity mentioned this pull request Mar 6, 2025

NetworkTransform's interpolator uses what looks like a configurable double lerp, with no way to configure it. #3112

Closed

style

91eca5f

removing white space

NoelStephensUnity added 6 commits March 6, 2025 11:54

update - pvp

639fbf8

Adding updates to resolve PVP issues for NetworkTransform.

update - pvp

f369d09

Fixing the remainder of the PVP issues within the components area.

style

be8e176

Fixing minor text issues with the newly added XML API documentation.

update

7000fae

Putting back the T Update(float deltaTime, NetworkTime serverTime) method and marking it as being deprectated.

test

0fe85d2

Adding a smooth dampening pass to the NestedNetworkTransformTests.

update

e453cdf

adding change log entries

NoelStephensUnity marked this pull request as ready for review March 6, 2025 19:16

NoelStephensUnity requested a review from a team as a code owner March 6, 2025 19:16

NoelStephensUnity added 8 commits March 6, 2025 14:20

Merge branch 'develop-2.0.0' into fix/networktransform-double-lerp-MT…

f649ba4

…TB-539

style

bed3a33

Adding additional comment on the max delta time calculation.

Merge branch 'fix/networktransform-double-lerp-MTTB-539' of https://g…

4121985

…ithub.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networktransform-double-lerp-MTTB-539

update

354b036

Fixing some xml api text issues. Making sure we are clearing the interpolator when reaching the maximum boundary.

update

15a6f9f

Adding indentions to the new NetworkTransform inspector view properties grouping.

Merge branch 'develop-2.0.0' into fix/networktransform-double-lerp-MT…

bdb9586

…TB-539

update

a51365f

Moving the property field draw method into the NetcodeEditorBase class in case we wanted to expose it at a later date and/or want to use it for another I-view control.

Merge branch 'fix/networktransform-double-lerp-MTTB-539' of https://g…

536da81

…ithub.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/networktransform-double-lerp-MTTB-539

danni-lu self-assigned this Mar 7, 2025

danni-lu self-requested a review March 7, 2025 17:50

danni-lu approved these changes Mar 7, 2025

View reviewed changes

NoelStephensUnity added 3 commits March 7, 2025 12:45

update

ee37977

Adding final touches to the UI updates for the NetworkTransformEditor. Also did a PVP pass for all of the editor related classes.

update

08dc79a

Fixing some access permissions and sorting through what we are ready to release as a public API.

update

4fe72f5

Some more adjustments to permissions and some final clean up of BufferedLinearInterpolator<T>

EmandM approved these changes Mar 13, 2025

View reviewed changes

NoelStephensUnity mentioned this pull request Mar 14, 2025

update: NetworkTransform SmoothDampening Updates Unity-Technologies/com.unity.multiplayer.docs#1443

Merged

3 tasks

Merge branch 'develop-2.0.0' into fix/networktransform-double-lerp-MT…

70a6edb

…TB-539

NoelStephensUnity enabled auto-merge (squash) March 14, 2025 03:11

NoelStephensUnity merged commit 16c4409 into develop-2.0.0 Mar 14, 2025
27 checks passed

NoelStephensUnity deleted the fix/networktransform-double-lerp-MTTB-539 branch March 14, 2025 04:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: networktransform double lerp (MTTB-539)#3337

fix: networktransform double lerp (MTTB-539)#3337
NoelStephensUnity merged 47 commits intodevelop-2.0.0from
fix/networktransform-double-lerp-MTTB-539

NoelStephensUnity commented Mar 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

NoelStephensUnity commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Testing and Documentation

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NoelStephensUnity commented Mar 5, 2025 •

edited

Loading