refactor: Remove defines based on UTP version#3362
Merged
NoelStephensUnity merged 8 commits intodevelop-2.0.0from Mar 26, 2025
Merged
refactor: Remove defines based on UTP version#3362NoelStephensUnity merged 8 commits intodevelop-2.0.0from
NoelStephensUnity merged 8 commits intodevelop-2.0.0from
Conversation
simon-lemay-unity
requested review from
a team,
EmandM,
NoelStephensUnity,
fluong6,
michalChrobot and
miniwolf
as code owners
|
|
simon-lemay-unity
changed the title
NoelStephensUnity
approved these changes
Mar 25, 2025
Member
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Lots of things and stuff removed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There used to be a time when NGO supported both UTP 1.X and 2.X, which led to the use of defines like
UTP_TRANSPORT_2_0_ABOVEto gate features that were only usable with UTP 2.X (or by proxy to differentiate code that was different for collections 1.X verus 2.X). In some files (likeUnityTransport.cs) these defines are used abundantly, to the point of impacting code readability.But NGO 2.X now depends on UTP 2.X, so these defines are now useless since they'll always be defined. This PR thus removes them. Functionally speaking this PR should change absolutely nothing since it just removes code that was never compiled anyway.
Changelog
N/A
Testing and Documentation