Skip to content

fix: network time system tests should use double fixed delta time#3373

Merged
NoelStephensUnity merged 3 commits intodevelopfrom
fix/NetworkTimeSystemTests-should-use-doubles
Apr 1, 2025
Merged

fix: network time system tests should use double fixed delta time#3373
NoelStephensUnity merged 3 commits intodevelopfrom
fix/NetworkTimeSystemTests-should-use-doubles

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

Adding the support to use a double delta time for NetworkTimeSystemTests.

Changelog

NA

Testing and Documentation

  • Includes update to the NetworkTimeSystemTests.CorrectAmountTicksTest integration test.
  • No documentation changes or additions were necessary.

Adding NetworkTime.FixedDeltaTimeAsDouble property to provide a double version of the NetworkTime.FixedDeltaTime.
Updating the `NetworkTimeSystemTests.CorrectAmountTicksTest` to use the `NetworkTime.FixedDeltaTimeAsDouble` as opposed to the `NetworkTime.FixedDeltaTime`. Adding additional debug information in the event it fails in the future we will have more information.
Copy link
Copy Markdown
Member

@michalChrobot michalChrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoelStephensUnity NoelStephensUnity merged commit b6d32f0 into develop Apr 1, 2025
40 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/NetworkTimeSystemTests-should-use-doubles branch April 1, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants