fix: NetworkBehaviour and NetworkVariableDelta length safety checks#3405
Merged
EmandM merged 12 commits intodevelop-2.0.0from May 20, 2025
Merged
Conversation
…/com.unity.netcode.gameobjects into fix/2.x/mttb-1080/network-object-length-serialization
…ngth-serialization
…ngth-serialization
NoelStephensUnity
pushed a commit
that referenced
this pull request
Apr 25, 2025
…ecks (#3415) <!-- Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. --> <!-- Add short version of the JIRA ticket to the PR title (e.g. "feat: new shiny feature [MTT-123]") --> [MTTB-1080](https://jira.unity3d.com/browse/MTTB-1080) 1.x for #3335 ## Changelog - Fixed: NetworkBehaviour length safety checks use `int` instead of `ushort` - Fixed: NetworkVariable `EnsureNetworkVariableLengthSafety` checks use `int` instead of `ushort` ## Testing and Documentation - No tests have been added. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. --> ## Backport <!-- If this is a backport: - Add the following to the PR title: "\[Backport\] ..." . - Link to the original PR. If this needs a backport - state this here If a backport is not needed please provide the reason why. If the "Backports" section is not present it will lead to a CI test failure. --> This is a backport of #3405 --------- Co-authored-by: Michał Chrobot <124174716+michalChrobot@users.noreply.github.com>
Member
Author
|
CMB service fixes implemented in https://github.com/Unity-Technologies/mps-common-multiplayer-backend/pull/1099. |
…/com.unity.netcode.gameobjects into fix/2.x/mttb-1080/network-object-length-serialization
com.unity.netcode.gameobjects/TestHelpers/Runtime/NetcodeIntegrationTest.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/TestHelpers/Runtime/NetcodeIntegrationTest.cs
Outdated
Show resolved
Hide resolved
...ity.netcode.gameobjects/Tests/Runtime/DistributedAuthority/DistributedAuthorityCodecTests.cs
Outdated
Show resolved
Hide resolved
NoelStephensUnity
approved these changes
May 19, 2025
Member
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Looks good.
Went ahead and added some of the suggested fixes for the test failures and also fixed a timing issue with the test project NetworkAnimator test (uses time travel).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MTTB-1080
fixes: #3335
Changelog
intinstead ofushortEnsureNetworkVariableLengthSafetychecks useintinstead ofushortDistributedAuthorityModeandEnsureNetworkVariableLengthSafetyTesting and Documentation
Backport
Backported in #3415