fix: tools metrics dispatcher related memory leak#3427
Merged
NoelStephensUnity merged 3 commits intodevelop-2.0.0from Apr 25, 2025
Merged
fix: tools metrics dispatcher related memory leak#3427NoelStephensUnity merged 3 commits intodevelop-2.0.0from
NoelStephensUnity merged 3 commits intodevelop-2.0.0from
Conversation
playModeStateChanged never gets unsubscribed
|
|
Member
|
Should this also be ported to |
NoelStephensUnity
added
the
port:1.x-needed
NoelStephensUnity
added
port:1.x-completed
NoelStephensUnity
added a commit
that referenced
this pull request
Apr 25, 2025
playModeStateChanged never gets unsubscribed in NetworkManager and keeps Multiplayer Tools MetricsDispatcher instances alive through NetworkMetrics when domain reload is disabled. Jira ticket: [MTT-11638](https://jira.unity3d.com/browse/MTT-11638) ## Changelog - Fixed: Memory leaks when domain reload is disabled. ## Testing and Documentation - No tests have been added. ## Backport This is a backport of #3427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playModeStateChanged never gets unsubscribed in NetworkManager and keeps Multiplayer Tools MetricsDispatcher instances alive through NetworkMetrics when domain reload is disabled.
Jira ticket: MTT-11638
Changelog
Testing and Documentation
Backport
Requires backport to v1.x. (#3428)