Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts Unity Toon Shader graphics test infrastructure to support XR MockHMD render-mode switching on macOS URP test runs, addressing a Metal decal-related rendering constraint.
Changes:
- Added a new assembly reference in the graphics test
.asmdefto support MockHMD usage. - Introduced a URP + macOS-specific workaround to set MockHMD render mode to MultiPass for decal scenes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| com.unity.toon-graphics-test/Runtime/Unity.ToonShader.GraphicsTest.asmdef | Adds an additional assembly reference GUID required for the new MockHMD usage in tests. |
| com.unity.toon-graphics-test/Runtime/UTSGraphicsTests.cs | Adds URP macOS logic to configure MockHMD render mode for decal scenes before enabling XR. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 403ebaf)