<feat>(GH-3077):<Android>: UnityAds adapter context handling#29
Open
AnwarissaAsbah wants to merge 3 commits into
Open
<feat>(GH-3077):<Android>: UnityAds adapter context handling#29AnwarissaAsbah wants to merge 3 commits into
AnwarissaAsbah wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Unity Ads mediation adapter’s interstitial and rewarded show-time context handling so non-Activity contexts no longer fail before calling Unity Ads.
Changes:
- Passes
nullactivity to Unity Ads show calls when the provided context is not anActivity. - Updates interstitial and rewarded tests to verify the new non-
Activitybehavior. - Removes an unused Unity adapter error message constant.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
ThirdPartyAdapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityInterstitialAd.java |
Uses a nullable Activity when showing interstitial ads. |
ThirdPartyAdapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityRewardedAd.java |
Removes rewarded show-time non-Activity failure path and passes nullable activity to Unity Ads. |
ThirdPartyAdapters/unity/unity/src/main/java/com/google/ads/mediation/unity/UnityMediationAdapter.java |
Removes unused context-null error message constant. |
ThirdPartyAdapters/unity/unity/src/test/kotlin/com/google/ads/mediation/unity/UnityInterstitialAdTest.kt |
Adds coverage for showing with a non-Activity context. |
ThirdPartyAdapters/unity/unity/src/test/kotlin/com/google/ads/mediation/unity/UnityRewardedAdTest.kt |
Updates non-Activity show behavior coverage for rewarded ads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove context checks at load and show (for both IS and RV) time as it blocks ad loading and showing when context is not a valid activity.