Skip to content

fix: GameLift allocator MatchProperties Region and MaxPlayers#16

Merged
Chellybean merged 3 commits into
mainfrom
fix/gamelift-allocator-maxplayers
Mar 25, 2026
Merged

fix: GameLift allocator MatchProperties Region and MaxPlayers#16
Chellybean merged 3 commits into
mainfrom
fix/gamelift-allocator-maxplayers

Conversation

@Chellybean

Copy link
Copy Markdown
Contributor

Pull Request

Description

GameLift allocator uses the MatchProperties MaxPlayers and Region

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Security fix
  • Performance improvement

Provider Integration

  • GameLift
  • Multiplay
  • PlayFab
  • New Provider Integration
  • General/Infrastructure
  • Documentation

Related Issues

N/A

Changes Made

GameLift allocator sample uses MaxPlayers and Region

Testing

  • Tested locally
  • Tested with actual provider integration
  • Added/updated unit tests
  • Verified no breaking changes

Security Checklist

  • No credentials, API keys, or secrets committed
  • Ran secret scan before committing
  • Reviewed all changes for sensitive data
  • Updated .gitignore if needed
  • Followed security best practices from SECURITY.md

Code Provenance

  • All code is original work created by me
  • I have the right to submit this code under the Unity Companion License
  • I did not copy code verbatim from provider documentation without attribution
  • No proprietary or confidential code is included
  • All third-party code is properly attributed and licensed

License Agreement

  • I agree to license my contributions under the Unity Companion License
  • I understand that Unity retains all rights to contributed code as specified in the license
  • I have read and agree to the terms in CONTRIBUTING.md

Documentation

  • Updated README.md if needed
  • Updated CONFIGURATION.md for affected modules
  • Added/updated code comments
  • No documentation changes needed

Provider Terms Compliance

  • Changes do not violate provider terms of service
  • Changes do not encourage violation of rate limits or usage policies
  • Provider names used descriptively without implying endorsement
  • No provider logos or branding materials added

Additional Notes

Community Support Acknowledgment

  • I understand this is a community-driven project
  • I understand reviews are conducted on a best-effort basis
  • I am willing to address review feedback

lucy-yuan
lucy-yuan previously approved these changes Mar 11, 2026
lucy-yuan
lucy-yuan previously approved these changes Mar 12, 2026
konqui0
konqui0 previously approved these changes Mar 13, 2026
DSchroer
DSchroer previously approved these changes Mar 16, 2026
@Chellybean Chellybean dismissed stale reviews from DSchroer, konqui0, and lucy-yuan via a011764 March 25, 2026 13:25
@Chellybean Chellybean merged commit ab17a38 into main Mar 25, 2026
8 checks passed
@Chellybean Chellybean deleted the fix/gamelift-allocator-maxplayers branch March 25, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants