Skip to content

Rename Allocators to use correct MatchProperties value format#21

Merged
nikbanerjee-unity merged 2 commits into
mainfrom
fix/match-properties-value
Apr 21, 2026
Merged

Rename Allocators to use correct MatchProperties value format#21
nikbanerjee-unity merged 2 commits into
mainfrom
fix/match-properties-value

Conversation

@FelixWentworth-Unity

Copy link
Copy Markdown
Contributor

Pull Request

Description

Align MatchProperties.GetValueOrDefault() requests to use values in the correct format across sample allocators

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Security fix
  • Performance improvement

Provider Integration

  • GameLift
  • Multiplay
  • PlayFab
  • New Provider Integration
  • General/Infrastructure
  • Documentation

Related Issues

Relates to #20

Changes Made

  • Change instances of "region" to use "Region" across allocators

Testing

  • Tested locally
  • Tested with actual provider integration
  • Added/updated unit tests
  • Verified no breaking changes

Security Checklist

  • No credentials, API keys, or secrets committed
  • Ran secret scan before committing
  • Reviewed all changes for sensitive data
  • Updated .gitignore if needed
  • Followed security best practices from SECURITY.md

Code Provenance

  • All code is original work created by me
  • I have the right to submit this code under the Unity Companion License
  • I did not copy code verbatim from provider documentation without attribution
  • No proprietary or confidential code is included
  • All third-party code is properly attributed and licensed

License Agreement

  • I agree to license my contributions under the Unity Companion License
  • I understand that Unity retains all rights to contributed code as specified in the license
  • I have read and agree to the terms in CONTRIBUTING.md

Documentation

  • Updated README.md if needed
  • Updated CONFIGURATION.md for affected modules
  • Added/updated code comments
  • No documentation changes needed

Provider Terms Compliance

  • Changes do not violate provider terms of service
  • Changes do not encourage violation of rate limits or usage policies
  • Provider names used descriptively without implying endorsement
  • No provider logos or branding materials added

Additional Notes

Community Support Acknowledgment

  • I understand this is a community-driven project
  • I understand reviews are conducted on a best-effort basis
  • I am willing to address review feedback

@nikbanerjee-unity nikbanerjee-unity merged commit 14da515 into main Apr 21, 2026
8 checks passed
@nikbanerjee-unity nikbanerjee-unity deleted the fix/match-properties-value branch April 21, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants