feat: allow dash as ID_STRICT for imports#57
Conversation
|
Thanks a lot for your PR and all your contributions to UVL over the last months in general @MiriamGaus! |
|
You're right. The given model isn't parsed, although it should be possible to parse. With enforcing spaces there is no ambiguity anymore. I'm not sure whether this is a wanted solution. Even though spaces provide a better readability for the constraints. |
|
I am not sure about enforcing spaces as well. I do not hate it in general, but it would probably require more substantial changes in the way we parse. |
|
I think this could fix the issue, I tried it and this already works. This should be added to the documentation. |
6d769ec to
9863d8e
Compare
9863d8e to
34a3658
Compare
|
I am heavily in favor of applying your proposed change, but I also think we should be generally cautious when changing the semantics of the language/ the base parser. We should probably get feedback of more involved parties on this prior to merging. Edit: I just understood that this required no change to the grammar at all. Then, I think we can merge right away. |
There was a problem hiding this comment.
Even though I do not mind this change here, we probably do not want to adapt files for visual structure in unrelated commits in general.
SundermannC
left a comment
There was a problem hiding this comment.
Thanks for updating the documentation. Looks good overall, I just have small change requests.
|
With the new bigger changes for the uvl parser, this PR becomes irrelevant and can be closed |
fixes #56