Never shrink configured read timeout during connect() setup

Address review feedback: connect() unconditionally set the setup-phase
read timeout to 10 s, even when getConfiguredReceiveTimeout() already
returned a larger value. That temporarily shrank the in-flight read
timeout during the openapi.json GET.

The worst case is the lazy-connect path inside commandPowerOn: power on
calls setReceiveTimeout(timeout) (typically 300 s by default), then
issues a PUT. If robot_api_version_ is still empty, put() lazy-calls
connect(), which would previously drop the 300 s back to 10 s for the
setup GET — exactly when the controller is booting and the GET most
needs the larger budget.

Treat the 10 s as a minimum-headroom for the setup GET, not a cap on
the caller's preferences: start from the configured value and only bump
up to 10 s if it is smaller. The save/restore around the GET still
honors whatever the caller had configured before connect() was entered.

Author: Vinicius-T-Robotics

src/ur/dashboard_client_implementation_x.cpp

@@ -96,10 +96,19 @@ bool DashboardClientImplX::connect([[maybe_unused]] const size_t max_num_tries,
   // temporarily extend the read timeout for setup, then restore the configured value.
   // The restore must run on every exit, including exceptions from json::parse or
   // VersionInformation::fromString — hence the catch(...) rethrow guard.
+  //
+  // The 10 s here is a minimum-headroom for setup, not a cap on the caller's
+  // preferences. If the caller (or an enclosing call like commandPowerOn) has already
+  // configured a larger read timeout, never shrink it — a lazy connect() inside such a
+  // call would otherwise reduce the in-flight deadline during the openapi.json GET.
   timeval configured_tv = getConfiguredReceiveTimeout();
-  timeval setup_tv;
-  setup_tv.tv_sec = 10;
-  setup_tv.tv_usec = 0;
+  constexpr time_t kSetupMinSeconds = 10;
+  timeval setup_tv = configured_tv;
+  if (setup_tv.tv_sec < kSetupMinSeconds)
+  {
+    setup_tv.tv_sec = kSetupMinSeconds;
+    setup_tv.tv_usec = 0;
+  }
   setReceiveTimeout(setup_tv);
 
   bool result = false;