Check return value of setsockopt and guard by accepted=true

Author: urfeex

include/ur_client_library/comm/socket_t.h

@@ -71,6 +71,8 @@ typedef int socket_t;
 #  define MSG_NOSIGNAL 0
 #endif
 
+#include "ur_client_library/log.h"
+
 /*!
  * \brief Get the last socket error as an std::error_code
  *
@@ -92,3 +94,14 @@ inline std::system_error makeSocketError(const std::string& message)
 {
   return std::system_error(getLastSocketErrorCode(), message);
 }
+
+inline void setSocketOptionAndWarnOnError(socket_t socket, int level, int optname, const void* optval,
+                                          unsigned int optlen, const std::string& option_name)
+{
+  int result = ur_setsockopt(socket, level, optname, optval, optlen);
+  if (result != 0)
+  {
+    std::error_code error_code = getLastSocketErrorCode();
+    URCL_LOG_WARN("Failed to set socket option %s: %s", option_name.c_str(), error_code.message().c_str());
+  }
+}

src/comm/tcp_server.cpp

@@ -261,8 +261,11 @@ void TCPServer::handleConnect()
     }
   }
 
-  int flag = 1;
-  ur_setsockopt(client_fd, IPPROTO_TCP, TCP_NODELAY, &flag, sizeof(int));
+  if (accepted)
+  {
+    constexpr int flag = 1;
+    setSocketOptionAndWarnOnError(client_fd, IPPROTO_TCP, TCP_NODELAY, &flag, sizeof(flag), "TCP_NODELAY");
+  }
 
   {
     std::lock_guard<std::mutex> lk(callback_mutex_);