Commit cdd9988
committed
Use plain timeval members instead of unique_ptr for X timeouts
The std::unique_ptr<timeval> indirection was carried over from
DashboardClientImplG5, where it composes with TCPSocket's existing
unique_ptr<timeval> member. In DashboardClientImplX it bought nothing:
no nullable semantics are needed because the constructor now installs
a 10 s default that every getter falls back to anyway.
Replace recv_timeout_ and send_timeout_ with value-typed timeval
members defaulted to {10, 0}. setReceiveTimeout / setSendTimeout
assign directly; the getters return the member. Behavior is
preserved (verified end-to-end against a stalling-server test that
times connect() at the configured value).1 parent cae7489 commit cdd9988
2 files changed
Lines changed: 6 additions & 29 deletions
File tree
- include/ur_client_library/ur
- src/ur
Lines changed: 2 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
| 189 | + | |
| 190 | + | |
194 | 191 | | |
195 | 192 | | |
196 | 193 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
| 163 | + | |
174 | 164 | | |
175 | 165 | | |
176 | 166 | | |
177 | 167 | | |
178 | 168 | | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
| 169 | + | |
190 | 170 | | |
191 | 171 | | |
192 | 172 | | |
| |||
0 commit comments