Added registerTrajDoneCallback() for https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/pull/1341 - #358
Closed
mathias31415 wants to merge 1 commit into
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
==========================================
- Coverage 78.10% 77.36% -0.75%
==========================================
Files 92 92
Lines 4138 4135 -3
Branches 456 456
==========================================
- Hits 3232 3199 -33
- Misses 676 703 +27
- Partials 230 233 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
urfeex
reviewed
Jul 10, 2025
urfeex
left a comment
urfeex
left a comment
Member
There was a problem hiding this comment.
I think, a better approach might be to allow multiple callbacks registered in the driver. I'll make a PR for that.
Author
|
Closing as this is outdated due to PR #359 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See UniversalRobots/Universal_Robots_ROS2_Driver#1341 (comment)