Only update force mode scaling and damping when needed - #378
Closed
urrsk wants to merge 1 commit into
Closed
Conversation
To avoid any impact of calling the scaling or damping methods if no change to these values are needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 77.86% 77.10% -0.77%
==========================================
Files 92 92
Lines 4166 4162 -4
Branches 461 461
==========================================
- Hits 3244 3209 -35
- Misses 684 714 +30
- Partials 238 239 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
urfeex
approved these changes
Sep 18, 2025
urfeex
left a comment
urfeex
left a comment
Member
There was a problem hiding this comment.
That seems fair and tested that it works properly.
Member
|
The original problem was resolved by #383. Therefore closing this. |
urrsk
deleted the
only_update_forcemode_scaling_and_damping_when_needed
branch
February 9, 2026 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid any impact of calling the scaling or damping methods if no change to these values are needed.