Make downloading and checking RTDE outputs from docs optional - #493
Merged
urfeex merged 1 commit intoApr 29, 2026
Merged
Conversation
It's not particularly nice to require internet access to build the project every time. Also, this reduces build requirements to run integration tests so we don't need python3 and pandas to run integration tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
==========================================
- Coverage 77.03% 76.76% -0.28%
==========================================
Files 113 113
Lines 6045 6042 -3
Branches 2637 2637
==========================================
- Hits 4657 4638 -19
- Misses 1055 1067 +12
- Partials 333 337 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
urfeex
marked this pull request as ready for review
April 28, 2026 11:20
urrsk
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not particularly nice to require internet access to build the project every time.
Also, this reduces build requirements to run integration tests so we don't need python3 and pandas to run integration tests.