Default to non_blocking_read=true#111
Merged
RobertWilbrandt merged 1 commit intoNov 15, 2023
Merged
Conversation
Since non-blocking-read showed significantly more stable behavior, we should default to that.
fmauch
force-pushed
the
non_blocking_read
branch
from
8096ea5 to
3769c90
Compare
RobertWilbrandt
approved these changes
Nov 15, 2023
RobertWilbrandt
left a comment
RobertWilbrandt
left a comment
Contributor
There was a problem hiding this comment.
Agreed, this seems like the overall better default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since non-blocking-read showed significantly more stable behavior, we should default to that. See UniversalRobots/Universal_Robots_ROS_Driver#615 for details.