Allow using the actual torques as joint efforts#1551
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
========================================
+ Coverage 3.59% 4.71% +1.12%
========================================
Files 13 35 +22
Lines 947 4517 +3570
Branches 152 535 +383
========================================
+ Hits 34 213 +179
- Misses 843 4299 +3456
+ Partials 70 5 -65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @urfeex , is there any intention to get this merged in the near future? As we are thinking about sim2real implementation, it makes it hard to compare between simulation and hardware. We get most of the information we need time synchronized from |
|
This just hasn't been a priority since I drafted out the concept for this. This is basically the case, since there seemingly was no interest in having this available. But I think, I should be able to get this to a mergeable state pretty quickly.
We can actually make a combination of both. Since reading the recipe file to a string vector is actually a static method, we can read it in the hardware interface, append the field if possible and then setup the |
be5ee47 to
941448f
Compare
|
That would be great! It seems like this change shouldn't negatively affect anything, so it would be awesome to have as an option! Thanks for taking a look! |
|
I think the state that it currently is in should be mergeable. This PR needs some polishing, especially on the documentation side, though. We will be branching out for lyrical pretty soon (before merging #1808), then we can also make this the default on Rolling from that point on. |
Add the option to use the joint_torques reported through RTDE as joint efforts as discussed in #1468.
This will not run on robots with software version < 5.23.0 / 10.11.0, hence the draft. The RTDE output for actual joints doesn't exist before. We would need to find a solution for that. Possible solutions are: