Fix stale linting issues

Author: K8Sewell

src/content-handlers/iiif/modules/iiif-av-component-module/Utils.ts

@@ -59,11 +59,11 @@ export class AVComponentUtils {
     canvases: Canvas[],
     target: string
   ): string | undefined {
-    let t: number[] | null = Utils.getTemporalComponent(target);
+    const t: number[] | null = Utils.getTemporalComponent(target);
 
     if (t) {
       let offset: number = 0;
-      let targetWithoutTemporal: string = target.substr(0, target.indexOf("#"));
+      const targetWithoutTemporal: string = target.substr(0, target.indexOf("#"));
 
       // loop through canvases adding up their durations until we reach the targeted canvas
       for (let i = 0; i < canvases.length; i++) {

src/content-handlers/iiif/modules/iiif-av-component-module/components/av-component.ts

@@ -1,7 +1,6 @@
-/* eslint-disable no-debugger */
-/* eslint-disable @typescript-eslint/no-unused-vars */
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
+ 
+ 
+ 
 const $ = require("jquery");
 require("jquery-ui-dist/jquery-ui");
 require("jquery-ui-dist/jquery-ui.css");
@@ -99,7 +98,7 @@ export class AVComponent extends BaseComponent {
   }
 
   public set(data: IAVComponentData): void {
-    // eslint-disable-next-line no-debugger
+     
     Logger.groupCollapsed("AVComponent.set()");
     Logger.log("Data", data);
 

src/content-handlers/iiif/modules/iiif-av-component-module/components/canvas-instance.ts

@@ -1,6 +1,5 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
-/* eslint-disable @typescript-eslint/no-unused-vars */
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
+ 
+ 
 import { convertToPercentage } from "../helpers/convert-to-percentage";
 
 const $ = require("jquery");
@@ -227,8 +226,9 @@ export class CanvasInstance extends BaseComponent {
 
     // this._renderSyncIndicator(data)
 
-    // @ts-ignore
-    const plan = createTimePlansFromManifest(
+    // upstream passes a second argument that createTimePlansFromManifest
+    // ignores; cast keeps the call as-is without a line-fragile @ts-ignore
+    const plan = (createTimePlansFromManifest as any)(
       helper.manifest as any,
       mediaElements
     );
@@ -437,7 +437,7 @@ export class CanvasInstance extends BaseComponent {
       this._canvasHeight = canvasHeight;
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-this-alias
+     
     const that = this;
 
     let prevClicks = 0;
@@ -1180,7 +1180,7 @@ export class CanvasInstance extends BaseComponent {
           this._$durationHighlight.hide();
         }
 
-        // eslint-disable-next-line @typescript-eslint/no-this-alias
+         
         const that = this;
 
         // try to destroy existing rangeTimelineContainer
@@ -1464,11 +1464,11 @@ export class CanvasInstance extends BaseComponent {
 
     data.timeout = null;
 
-    // eslint-disable-next-line @typescript-eslint/no-this-alias
+     
     const that = this;
 
     data.checkForStall = function () {
-      // eslint-disable-next-line @typescript-eslint/no-this-alias
+       
       const self = this;
 
       if (this.active) {

src/content-handlers/iiif/modules/iiif-av-component-module/components/volume-control.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/no-unused-vars */
+ 
 const $ = require("jquery");
 import { IAVVolumeControlState } from "../interfaces/volume-control-state";
 import { BaseComponent, IBaseComponentOptions } from "@iiif/base-component";
@@ -42,7 +42,7 @@ export class AVVolumeControl extends BaseComponent {
 
     this._$element.append(this._$volumeMute, this._$volumeSlider);
 
-    // eslint-disable-next-line @typescript-eslint/no-this-alias
+     
     const that = this;
 
     this._$volumeMute.on("touchstart click", (e) => {

src/content-handlers/iiif/modules/iiif-av-component-module/globals.d.ts

@@ -14,7 +14,7 @@ declare let jQuery: any;
 // Declared here rather than via @types/jqueryui, whose non-generic JQuery
 // interface declaration conflicts with @types/jquery v3. switchClass is
 // already declared globally in src/globals.d.ts.
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
+ 
 interface JQuery<TElement = HTMLElement> {
   slider(...args: any[]): any;
 }

src/content-handlers/iiif/modules/iiif-av-component-module/helpers/debounce.ts

@@ -11,7 +11,7 @@ export function debounce(fn: any, debounceDuration: number): any {
 
   return function () {
     if (!fn.debouncing) {
-      // eslint-disable-next-line prefer-rest-params
+       
       const args: any = Array.prototype.slice.apply(arguments);
       fn.lastReturnVal = fn.apply(window, args);
       fn.debouncing = true;

src/content-handlers/iiif/modules/iiif-av-component-module/helpers/get-spatial-component.ts

@@ -3,7 +3,7 @@ export function getSpatialComponent(target: string): number[] | null {
   let xywh: number[] | null = null;
 
   if (spatial && spatial[1]) {
-    // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
+     
     xywh = <any>spatial[1].split(",");
   }
 

src/content-handlers/iiif/modules/iiif-av-component-module/interfaces/canvas-instance-data.ts

@@ -2,7 +2,6 @@ import { IAVComponentData } from "./component-data";
 import { VirtualCanvas } from "../elements/virtual-canvas";
 import { Canvas, Range } from "manifesto.js";
 
-// eslint-disable-next-line @typescript-eslint/interface-name-prefix
 export interface IAVCanvasInstanceData extends IAVComponentData {
   canvas?: Canvas | VirtualCanvas;
   range?: Range;

src/content-handlers/iiif/modules/iiif-av-component-module/interfaces/component-content.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line @typescript-eslint/interface-name-prefix
 export interface IAVComponentContent {
   currentTime: string;
   collapse: string;

src/content-handlers/iiif/modules/iiif-av-component-module/interfaces/component-data.ts

@@ -1,7 +1,6 @@
 import { Helper } from "@iiif/manifold";
 import { IAVComponentContent } from "./component-content";
 
-// eslint-disable-next-line @typescript-eslint/interface-name-prefix
 export interface IAVComponentData {
   [key: string]: any;
   adaptiveAuthEnabled?: boolean;