(old) fix adjust image background#1415
Closed
crhallberg wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
previously approved these changes
May 14, 2025
demiankatz
left a comment
demiankatz
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @crhallberg, I think this is a big improvement!
Should we rebase this against the release-4.2.0 branch so we can include it in the next release, or would people feel better keeping this against dev for inclusion in 4.3 instead?
crhallberg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced by #1418.
Having the half-shaded and textured background behind the adjust image overlay makes those adjustments a guessing game. Moving the style adjustment down fixes the proper order of operations to remove the background.
Also: