Skip to content

Commit 3758b46

Browse files
committed
Fix
1 parent deb6b19 commit 3758b46

3 files changed

Lines changed: 2 additions & 19 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Logs
22
logs
33
*.log
4+
unleash-node-sdk
45

56
# Runtime data
67
pids

src/main/java/io/getunleash/impactmetrics/CounterImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ public void inc(long value, Map<String, String> labels) {
3434
values.compute(key, (k, current) -> (current == null ? 0L : current) + value);
3535
}
3636

37+
@Override
3738
public CollectedMetric collect() {
3839
List<NumericMetricSample> samples = new ArrayList<>();
3940

src/test/java/io/getunleash/impactmetrics/CounterImplTest.java

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -107,24 +107,5 @@ public void should_reset_after_collect() {
107107
assertThat(second.getSamples().get(0).getValue()).isEqualTo(0L);
108108
}
109109

110-
@Test
111-
public void should_generate_stable_label_key() {
112-
Map<String, String> labels1 = Map.of("z", "1", "a", "2");
113-
Map<String, String> labels2 = Map.of("a", "2", "z", "1");
114-
115-
String key1 = CounterImpl.getLabelKey(labels1);
116-
String key2 = CounterImpl.getLabelKey(labels2);
117-
118-
assertThat(key1).isEqualTo(key2);
119-
assertThat(key1).isEqualTo("a=2,z=1");
120-
}
121110

122-
@Test
123-
public void should_parse_label_key_correctly() {
124-
String key = "env=prod,region=us-east";
125-
126-
Map<String, String> labels = CounterImpl.parseLabelKey(key);
127-
128-
assertThat(labels).containsEntry("env", "prod").containsEntry("region", "us-east");
129-
}
130111
}

0 commit comments

Comments
 (0)