Fix DI

Author: sjaanus

src/main/java/io/getunleash/metric/UnleashMetricServiceImpl.java

@@ -4,7 +4,6 @@
 import io.getunleash.engine.UnleashEngine;
 import io.getunleash.impactmetrics.CollectedMetric;
 import io.getunleash.impactmetrics.ImpactMetricsDataSource;
-import io.getunleash.impactmetrics.InMemoryMetricRegistry;
 import io.getunleash.util.Throttler;
 import io.getunleash.util.UnleashConfig;
 import io.getunleash.util.UnleashScheduledExecutor;
@@ -48,9 +47,7 @@ public UnleashMetricServiceImpl(
                         300,
                         unleashConfig.getUnleashURLs().getClientMetricsURL());
         this.engine = engine;
-        ImpactMetricsDataSource configuredRegistry = unleashConfig.getImpactMetricsRegistry();
-        this.impactMetricsRegistry =
-                configuredRegistry != null ? configuredRegistry : new InMemoryMetricRegistry();
+        this.impactMetricsRegistry = unleashConfig.getImpactMetricsRegistry();
         long metricsInterval = unleashConfig.getSendMetricsInterval();
 
         executor.setInterval(sendMetrics(), metricsInterval, metricsInterval);

src/main/java/io/getunleash/util/UnleashConfig.java

@@ -74,7 +74,7 @@ public class UnleashConfig {
     @Nullable private final ToggleBootstrapProvider toggleBootstrapProvider;
     @Nullable private final Proxy proxy;
     @Nullable private final Consumer<UnleashException> startupExceptionHandler;
-    @Nullable private final ImpactMetricsDataSource impactMetricsRegistry;
+    private final ImpactMetricsDataSource impactMetricsRegistry;
 
     private UnleashConfig(
             @Nullable URI unleashAPI,
@@ -109,7 +109,7 @@ private UnleashConfig(
             @Nullable Proxy proxy,
             @Nullable Authenticator proxyAuthenticator,
             @Nullable Consumer<UnleashException> startupExceptionHandler,
-            @Nullable ImpactMetricsDataSource impactMetricsRegistry) {
+            ImpactMetricsDataSource impactMetricsRegistry) {
 
         if (appName == null) {
             throw new IllegalStateException("You are required to specify the unleash appName");
@@ -356,7 +356,6 @@ public Proxy getProxy() {
         return proxy;
     }
 
-    @Nullable
     public ImpactMetricsDataSource getImpactMetricsRegistry() {
         return impactMetricsRegistry;
     }
@@ -766,7 +765,8 @@ public UnleashConfig build() {
                     proxy,
                     proxyAuthenticator,
                     startupExceptionHandler,
-                    impactMetricsRegistry);
+                    Optional.ofNullable(impactMetricsRegistry)
+                            .orElseGet(io.getunleash.impactmetrics.InMemoryMetricRegistry::new));
         }
 
         public String getDefaultSdkVersion() {