feat: backup file on streaming#323
Merged
Merged
Conversation
kwasniew
commented
Aug 20, 2025
| } | ||
|
|
||
| private synchronized void handleStreamingUpdate(String data) { | ||
| synchronized void handleStreamingUpdate(String data) { |
Contributor
Author
There was a problem hiding this comment.
for easier testing
kwasniew
commented
Aug 20, 2025
| engine.takeState(data); | ||
| // TODO: write backup when engine exposes current state | ||
|
|
||
| String currentState = engine.getState(); |
Contributor
Author
There was a problem hiding this comment.
the output from getState happens to match what we write as a backup file content
Collaborator
Pull Request Test Coverage Report for Build 17576309622Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Contributor
Author
|
Reviewers: can you also check if the backup file is read on the initial failing streaming connection? |
github-project-automation
Bot
moved this from In Progress
to Approved PRs
in Issues and PRs
kwasniew
commented
Sep 9, 2025
| flag-name: run-jvm-${{ join(matrix.*, '-') }} | ||
| parallel: true | ||
| base-path: src/main/java | ||
| fail-on-error: ${{ matrix.os != 'macos' }} |
Contributor
Author
There was a problem hiding this comment.
coverallsapp/homebrew-coveralls#65 (comment) following this advice before coveralls starts working with macos 15.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the changes
Save full ygg engine state string to a backup file
Important files
Discussion points