chore: resolve a bunch of linter warnings, no logic changes#334
chore: resolve a bunch of linter warnings, no logic changes#334
Conversation
Pull Request Test Coverage Report for Build 19922642557Details
💛 - Coveralls |
|
|
||
| private static ConcurrentHashMap<String, LongAdder> initCounts = new ConcurrentHashMap<>(); | ||
|
|
||
| private final UnleashMetricService metricService; |
There was a problem hiding this comment.
All handled by the EngineProxy
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class UnleashMetricServiceImpl implements UnleashMetricService { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(UnleashMetricServiceImpl.class); |
| @Override | ||
| public Future<Void> scheduleOnce(Runnable runnable) { | ||
| return (Future<Void>) executorService.submit(runnable); | ||
| return executorService.submit( |
There was a problem hiding this comment.
Think this was just wrong but didn't matter because the result wasn't really used. Pretty sure this is correct but still won't matter
Linter stops freaking though, which is nice
| @@ -23,9 +23,7 @@ | |||
| import io.getunleash.util.UnleashConfig; | |||
There was a problem hiding this comment.
Mostly a bunch of unuseds which don't impact the test runs in anyway
| .thenReturn(new FlatResponse<Boolean>(false, null)); | ||
| Unleash unleash = new DefaultUnleash(baseConfig, engineProxy); | ||
|
|
||
| @SuppressWarnings("unchecked") |
There was a problem hiding this comment.
Think this is correct thing to do here. Mocking is runtime goop so I don't think this has a meaningful way to determine the type
| @@ -1,4 +1,4 @@ | |||
| package io.getunleash.integration; | |||
| package io.getunleash.streaming; | |||
There was a problem hiding this comment.
Not sure why this was in the integration package. It's alone in there, doesn't match it's actual package structure and that doesn't follow the pattern for our test packages anyway
|
|
||
| this.config = unleashConfig; | ||
| this.featureRepository = engineProxy; | ||
| this.metricService = engineProxy; |
There was a problem hiding this comment.
All handled by the EngineProxy
But but..
daveleek
left a comment
daveleek
left a comment
There was a problem hiding this comment.
Cool, so primarily cleaning up a bunch of assigned but unused variables, with some additional cleanup sprinkled on top in tests. 
4 participants
Don't think this makes any logical changes but it stops my IDE screaming at me in a bunch of places