Conversation
Due to a bug in Yggdrasil, multiple instances of the same custom strategy overwrote each other so last one won. After this bug fix, Yggdrasil again evaluates all custom strategies on an OR base, so if any are true, the flag will be true fixes: #369
Collaborator
Pull Request Test Coverage Report for Build 22174764844Details
💛 - Coveralls |
github-project-automation
Bot
moved this from In Progress
to Approved PRs
in Issues and PRs
chriswk
deleted the
369-adding-the-same-custom-strategy-multiple-times-on-a-feature-flag-does-not-evaluate-all-instances-last-one-wins
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a bug in Yggdrasil, multiple instances of the same custom strategy overwrote each other so last one won. After this bug fix, Yggdrasil again evaluates all custom strategies on an OR base, so if any are true, the flag will be true.
This PR also adds a test testing just this case in order to prevent a regression in the future.
fixes: #369