fix: missing linting after rebasing from main

Author: chriswk

src/repository/bootstrap-provider.ts

@@ -1,9 +1,9 @@
-import { promises } from 'fs';
-import { ClientFeaturesResponse, FeatureInterface } from '../feature';
-import { CustomHeaders } from '../headers';
-import { buildHeaders, getDefaultAgent } from '../request';
+import { promises } from 'node:fs';
+import type { ClientFeaturesResponse, FeatureInterface } from '../feature';
+import type { CustomHeaders } from '../headers';
 import { getKyClient } from '../http-client';
-import { Segment } from '../strategy/strategy';
+import { buildHeaders, getDefaultAgent } from '../request';
+import type { Segment } from '../strategy/strategy';
 
 export interface BootstrapProvider {
   readBootstrap(): Promise<ClientFeaturesResponse | undefined>;
@@ -55,8 +55,9 @@ export class DefaultBootstrapProvider implements BootstrapProvider {
         contentType: undefined,
         custom: this.urlHeaders,
       }),
+      // @ts-expect-error passed on to fetch
       agent: getDefaultAgent,
-    } as any);
+    });
     if (response.ok) {
       return response.json();
     }

src/repository/polling-fetcher.ts

@@ -1,4 +1,5 @@
-import { EventEmitter } from 'events';
+import { EventEmitter } from 'node:events';
+import { UnleashEvents } from '../events';
 import { parseClientFeaturesDelta } from '../feature';
 import { get } from '../request';
 import type { TagFilter } from '../tags';

src/request.ts

@@ -1,12 +1,13 @@
+import * as http from 'node:http';
+import * as https from 'node:https';
+import type { URL } from 'node:url';
 import { HttpProxyAgent } from 'http-proxy-agent';
 import { HttpsProxyAgent } from 'https-proxy-agent';
-import * as http from 'http';
-import * as https from 'https';
-import { URL } from 'url';
 import { getProxyForUrl } from 'proxy-from-env';
-import { CustomHeaders } from './headers';
-import { HttpOptions } from './http-options';
+import type { CustomHeaders } from './headers';
 import { defaultRetry, getKyClient } from './http-client';
+import type { HttpOptions } from './http-options';
+
 const details = require('./details.json');
 
 export interface RequestOptions {
@@ -161,7 +162,7 @@ export const post = async ({
     retry: defaultRetry,
   } as const;
 
-  return ky.post(url, requestOptions as any).catch((err: any) => {
+  return ky.post(url, requestOptions).catch((err) => {
     if (err?.response) {
       return err.response;
     }
@@ -198,8 +199,10 @@ export const get = async ({
     retry: defaultRetry,
   } as const;
 
-  return ky.get(url, requestOptions as any).catch((err: any) => {
+  return ky.get(url, requestOptions).catch((err: unknown) => {
+    // @ts-expect-error we declare as unknown, so won't have the type here
     if (err?.response) {
+      // @ts-expect-error we declare as unknown, so won't have the type here
       return err.response;
     }
     throw err;

src/test/repository/repository.test.ts

@@ -1020,7 +1020,7 @@ test('bootstrap should not override load backup-file', async () => {
   expect(repo.getToggle('feature-backup')?.enabled).toEqual(true);
 });
 
-test('Failing twice then succeeding should shrink interval to 2x initial (404)', async (t) => {
+test('Failing twice then succeeding should shrink interval to 2x initial (404)', async (_t) => {
   const url = 'http://unleash-test-fail5times.app';
   nock(url).get('/client/features').times(2).reply(404);
   const repo = new Repository({
@@ -1067,7 +1067,7 @@ test('Failing twice then succeeding should shrink interval to 2x initial (404)',
 
 // Skipped because the HTTP client automatically retries 429 responses,
 // which makes the test very slow.
-test.skip('Failing twice should increase interval to initial + 2x interval (429)', async (t) => {
+test.skip('Failing twice should increase interval to initial + 2x interval (429)', async (_t) => {
   const url = 'http://unleash-test-fail5times.app';
   nock(url).persist().get('/client/features').reply(429);
   const repo = new Repository({
@@ -1086,12 +1086,12 @@ test.skip('Failing twice should increase interval to initial + 2x interval (429)
   await repo.fetch();
   expect(2).toEqual(repo.getFailures());
   expect(30).toEqual(repo.nextFetch());
-  repo.stop()
+  repo.stop();
 });
 
 // Skipped because the HTTP client automatically retries 429 responses,
 // which makes the test very slow.
-test.skip('Failing twice then succeeding should shrink interval to 2x initial (429)', async (t) => {
+test.skip('Failing twice then succeeding should shrink interval to 2x initial (429)', async (_t) => {
   const url = 'http://unleash-test-fail5times.app';
   nock(url).persist().get('/client/features').reply(429);
   const repo = new Repository({