task: migrate to pnpm#860
Open
chriswk wants to merge 4 commits into
Open
Conversation
chriswk
requested review from
gastonfournier,
melindafekete and
sighphyre
as code owners
chriswk
commented
May 11, 2026
| "murmurhash3js": "^3.0.1", | ||
| "proxy-from-env": "^1.1.0", | ||
| "re2js": "^1.2.2", | ||
| "re2js": "^2.6.1", |
Member
Author
There was a problem hiding this comment.
This one, why did we use such an old re2js version?
Member
There was a problem hiding this comment.
It's not old, 1.2.2 was released in Feb. This is a major upgrade, what does the re2js changelog say about the change?
Coverage Report for CI Build 25671344779Coverage remained the same at 90.397%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Unleash OSS and unleash-enterprise are now migrated to pnpm, it seems smart to standardise on pnpm in our node repos.