fix: destructive modal close behavior#1138
Conversation
|
Warning Review limit reached
More reviews will be available in 59 minutes and 36 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds the ChangesModal Outside-Click Prevention Configuration
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
carddev81
left a comment
There was a problem hiding this comment.
Amazing work!!! Tested Good.
Pre-Submission PR Checklist
Description of the change
Fixes modal escape behavior on destructive actions like bulk user actions, and user transfers. Users can now only exit the modal through the x button, cancel, and escape key.
BulkActionDialogs.tsx — BulkResetPassword (L150), BulkDeactivate (L328), BulkDelete (L474)
ResidentDialogs.tsx — Deactivate (L344), Delete (L470), Transfer (L589)
DeleteClassModal.tsx (L50)
Related issues: https://app.asana.com/1/1201607307149189/project/1209460078641109/task/1215131538607872?focus=true