Skip to content

Use carbon instead of durafmt#636

Merged
davidnewhall merged 1 commit into
mainfrom
dn2_durafmt
Jun 15, 2026
Merged

Use carbon instead of durafmt#636
davidnewhall merged 1 commit into
mainfrom
dn2_durafmt

Conversation

@davidnewhall

Copy link
Copy Markdown
Collaborator

Switch time formatter from durafmt to carbon. Mostly a no-op, just a dependency change. Also a couple lint fixes.

@davidnewhall davidnewhall merged commit 63dfd08 into main Jun 15, 2026
23 of 24 checks passed
@davidnewhall davidnewhall deleted the dn2_durafmt branch June 15, 2026 04:29

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI diagnosis for the non-success check:

  • Failure: security/snyk (twitchcaptain) reported ERROR with description 1 test has failed; the GitHub Actions test/lint jobs were successful.
  • Cause: this PR introduced the new production dependency github.com/dromara/carbon/v2 in go.mod, which is the dependency change Snyk evaluated and failed.
  • Fix applied: replaced the carbon duration-formatting calls with a small local formatter using the Go standard library, then removed carbon from go.mod, go.sum, and the depguard allow-list.
  • Follow-up commit: bd7a316
  • Verification: go test ./pkg/unpackerr passed.

Follow-up PR with the fix: #637

View PR

Open in Web View Automation 

Sent by Cursor Automation: CI Failure Auto-Fixer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

durafmt is dead.

1 participant