Use carbon instead of durafmt#636
Merged
Merged
Conversation
There was a problem hiding this comment.
CI diagnosis for the non-success check:
- Failure:
security/snyk (twitchcaptain)reportedERRORwith description1 test has failed; the GitHub Actions test/lint jobs were successful. - Cause: this PR introduced the new production dependency
github.com/dromara/carbon/v2ingo.mod, which is the dependency change Snyk evaluated and failed. - Fix applied: replaced the
carbonduration-formatting calls with a small local formatter using the Go standard library, then removedcarbonfromgo.mod,go.sum, and the depguard allow-list. - Follow-up commit: bd7a316
- Verification:
go test ./pkg/unpackerrpassed.
Follow-up PR with the fix: #637
Sent by Cursor Automation: CI Failure Auto-Fixer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Switch time formatter from durafmt to carbon. Mostly a no-op, just a dependency change. Also a couple lint fixes.