Fix Snyk failure by removing carbon dependency#637
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Andreas Echavez <oceanplexian@users.noreply.github.com>
Collaborator
|
What was the Snyk error? |
Co-authored-by: Andreas Echavez <oceanplexian@users.noreply.github.com>
Author
There was a problem hiding this comment.
CI failure diagnosed and fixed.
- Failure:
golangci-lintfailed on linux and darwin withvarnamelenatpkg/unpackerr/duration.go, reporting parameter namedwas too short for its scope. - Cause:
formatDurationused the one-letter parameterdacross the function body, which violates the repo's enabledvarnamelenlint rule. - Fix: Renamed the parameter to
durationand updated the internal assignment so the name is descriptive and lint-compliant. - Follow-up commit: 35372a6
Validation: GOTOOLCHAIN=go1.26.4 go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2 run passed with 0 issues.
Sent by Cursor Automation: CI Failure Auto-Fixer
TheBadFella
added a commit
to TheBadFella/UnpackUI
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Removes the newly added
github.com/dromara/carbon/v2dependency and replaces its duration formatting usage with a small local formatter based on the Go standard library.Verification:
go test ./pkg/unpackerr