Skip to content

Fix Snyk failure by removing carbon dependency#637

Draft
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/ci-failure-resolution-04b3
Draft

Fix Snyk failure by removing carbon dependency#637
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/ci-failure-resolution-04b3

Conversation

@cursor

@cursor cursor Bot commented Jun 15, 2026

Copy link
Copy Markdown

Removes the newly added github.com/dromara/carbon/v2 dependency and replaces its duration formatting usage with a small local formatter based on the Go standard library.

Verification:

  • go test ./pkg/unpackerr
Open in Web View Automation 

Co-authored-by: Andreas Echavez <oceanplexian@users.noreply.github.com>
@cursor cursor Bot mentioned this pull request Jun 15, 2026
@davidnewhall

Copy link
Copy Markdown
Collaborator

What was the Snyk error?

davidnewhall and others added 2 commits June 16, 2026 11:32
Co-authored-by: Andreas Echavez <oceanplexian@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure diagnosed and fixed.

  • Failure: golangci-lint failed on linux and darwin with varnamelen at pkg/unpackerr/duration.go, reporting parameter name d was too short for its scope.
  • Cause: formatDuration used the one-letter parameter d across the function body, which violates the repo's enabled varnamelen lint rule.
  • Fix: Renamed the parameter to duration and updated the internal assignment so the name is descriptive and lint-compliant.
  • Follow-up commit: 35372a6

Validation: GOTOOLCHAIN=go1.26.4 go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2 run passed with 0 issues.

Open in Web View Automation 

Sent by Cursor Automation: CI Failure Auto-Fixer

TheBadFella added a commit to TheBadFella/UnpackUI that referenced this pull request Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants