Start collecting CRDs with nix#4032
Merged
Merged
Conversation
Owner
UnstoppableMango
commented
May 14, 2026
- Move flack check and nix files
- WIP
- Flake update
- MORE
- Even MORE crds
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Introduces a new flux flake-parts module for validating Flux configs and generating/collecting CRDs via Nix, and wires in nix-kube-generators for Kubernetes/YAML/Helm tooling.
Changes:
- Add
./fluxflake-parts module with packages + checks (flux validation, CRD collection). - Add CRD assembly pipeline (fetch/build Helm charts, slice CRDs, symlink results).
- Update flake inputs to include
nix-kube-generatorsand exposekubelibvialegacyPackages.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| flux/src.nix | Defines a source fileset for Flux-related evaluation/build inputs |
| flux/default.nix | Adds per-system Flux packages and a validate-flux check |
| flux/crds.nix | Implements fetching/building and slicing CRDs into a joined output |
| flake.nix | Registers the flux module, adds nix-kube-generators, and exposes kubelib |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.