fix(sharepoint): use to_json() for permissions and pin collection across accesses

Address review feedback:
- Use perm.to_json() instead of perm.properties to get plain dicts
- Pin PermissionCollection into drive_item.properties so batch
  results survive across property getter accesses
- Extract _pin_permissions helper to deduplicate the pin pattern
- Add pin assertion to fallback test

Author: brndnblck

test/unit/connectors/test_sharepoint.py

@@ -140,7 +140,7 @@ def test_fetch_file_handles_site_not_found_immediately(
 
 def _make_permission(raw_props: dict) -> Mock:
     perm = Mock()
-    perm.properties = raw_props
+    perm.to_json.return_value = raw_props
     return perm
 
 
@@ -428,7 +428,7 @@ class TestDriveItemToFileDataSync:
     def test_permissions_attached_when_pre_hydrated(self):
         indexer = _make_indexer()
         perm = Mock()
-        perm.properties = {
+        perm.to_json.return_value = {
             "roles": ["read"],
             "grantedToV2": {"user": {"id": "user-1"}},
         }
@@ -473,6 +473,7 @@ def test_falls_back_to_per_item_on_batch_failure(self):
         assert client._queries == []
         for item in items:
             assert item.permissions.get.return_value.execute_query.called
+            assert item.properties["permissions"] is item.permissions
 
     def test_fallback_works_without_internal_query_list(self):
         indexer = _make_indexer()

unstructured_ingest/processes/connectors/sharepoint.py

@@ -185,7 +185,7 @@ def extract_permissions(
         }
 
         for perm in permissions:
-            raw_props = perm.properties
+            raw_props = perm.to_json()
             roles = raw_props.get("roles", [])
 
             operations: set[str] = set()
@@ -212,6 +212,17 @@ def extract_permissions(
         logger.debug(f"normalized permissions generated: {result}")
         return [{k: v} for k, v in result.items()]
 
+    @staticmethod
+    def _pin_permissions(drive_item: DriveItem) -> Any:
+        """Pin the permissions collection into properties so it survives across accesses.
+
+        The property getter creates a fresh empty PermissionCollection each time
+        when the key is absent. Pinning ensures batch/query results are retained.
+        """
+        perms = drive_item.permissions
+        drive_item.properties["permissions"] = perms
+        return perms
+
     def _fetch_permissions_batched(
         self,
         client: Any,
@@ -226,7 +237,7 @@ def _fetch_permissions_batched(
         from office365.runtime.client_request_exception import ClientRequestException
 
         for drive_item in drive_items:
-            drive_item.permissions.get()
+            self._pin_permissions(drive_item).get()
 
         try:
             client.execute_batch(items_per_batch=PERMISSIONS_BATCH_SIZE)
@@ -241,7 +252,7 @@ def _fetch_permissions_batched(
                 pending_queries.clear()
             for drive_item in drive_items:
                 try:
-                    drive_item.permissions.get().execute_query()
+                    self._pin_permissions(drive_item).get().execute_query()
                 except ClientRequestException as exc:
                     logger.error(
                         f"failed to fetch permissions for {drive_item.name}: {exc}",