test: qdrant upload twice to test upsert behavior#321
Open
ds-filipknefel wants to merge 2 commits intomainfrom
Open
test: qdrant upload twice to test upsert behavior#321ds-filipknefel wants to merge 2 commits intomainfrom
ds-filipknefel wants to merge 2 commits intomainfrom
Conversation
ds-filipknefel
requested review from
mateuszkuprowski,
potter-potter and
rbiseck3
Comment on lines
1
to
3
| @@ -1,4 +1,4 @@ | |||
| ## 0.3.12-dev3 | |||
| ## 0.3.12-dev4 | |||
|
|
|||
| ### Enhancements | |||
Contributor
There was a problem hiding this comment.
Don't we want to update changelog with this fix/enchancement?
I mean, it all depends on whether we want to include dev updates here too, or only user-facing ones.
Comment on lines
-147
to
+160
| if uploader.is_async(): | ||
| await uploader.run_async(path=staged_upload_file, file_data=file_data) | ||
| else: | ||
| uploader.run(path=upload_file, file_data=file_data) | ||
| await uploader.run_async(path=staged_upload_file, file_data=file_data) | ||
| async with qdrant_client(connection_kwargs) as client: | ||
| await validate_upload(client=client, upload_file=upload_file) | ||
|
|
||
| # NOTE: Upload the second time to validate upsert behavior | ||
| await uploader.run_async(path=staged_upload_file, file_data=file_data) |
Contributor
There was a problem hiding this comment.
Just curious, why the previous change includes both async and sync run (if not async) but here you removed that and use async only?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend qdrant integration tests to upload the files twice to test the upsert behavior is working.