fix(notion): accept app.notion.com URLs after Notion domain migration#700
Open
fix(notion): accept app.notion.com URLs after Notion domain migration#700
Conversation
- Accept both www.notion.so and app.notion.com in is_page_url() and is_database_url() after Notion domain migration - Update integration test fixtures to match new URL format returned by the Notion API
awalker4
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
www.notion.soandapp.notion.cominis_page_url()andis_database_url()after Notion's domain migration.Details
www.notion.sotoapp.notion.com/p/URLs. The URL validation helpers inhelpers.pyhardcoded the old domain, rejecting URLs in the new format._NOTION_DOMAINStuple to centralize accepted domains and support both old and new formats for backwards compatibility.notion_pageandnotion_databaseexpected results) to reflect the new URL format.Note
Low Risk
Low risk: small change to Notion URL validation plus fixture/version bumps; main risk is misclassifying unusual Notion URL variants by domain parsing.
Overview
Updates the Notion connector URL validators (
is_page_url()/is_database_url()) to accept bothwww.notion.soand the newapp.notion.comdomains via a shared_NOTION_DOMAINSallowlist.Bumps the package version to
1.5.1, adds a changelog entry, and refreshes Notion integration test fixtures/expected outputs to the newapp.notion.com/p/...URL format.Reviewed by Cursor Bugbot for commit ae509e0. Bugbot is set up for automated code reviews on this repo. Configure here.