Skip to content

fix(notion): accept app.notion.com URLs after Notion domain migration#700

Open
brndnblck wants to merge 1 commit intomainfrom
brandon/fix-notion-url-domain
Open

fix(notion): accept app.notion.com URLs after Notion domain migration#700
brndnblck wants to merge 1 commit intomainfrom
brandon/fix-notion-url-domain

Conversation

@brndnblck
Copy link
Copy Markdown
Contributor

@brndnblck brndnblck commented May 1, 2026

Summary

  • Accept both www.notion.so and app.notion.com in is_page_url() and is_database_url() after Notion's domain migration.
  • Update integration test fixtures to match the new URL format returned by the Notion API.

Details

  • Notion migrated from www.notion.so to app.notion.com/p/ URLs. The URL validation helpers in helpers.py hardcoded the old domain, rejecting URLs in the new format.
  • Added _NOTION_DOMAINS tuple to centralize accepted domains and support both old and new formats for backwards compatibility.
  • Updated 3 fixture files (notion_page and notion_database expected results) to reflect the new URL format.

Note

Low Risk
Low risk: small change to Notion URL validation plus fixture/version bumps; main risk is misclassifying unusual Notion URL variants by domain parsing.

Overview
Updates the Notion connector URL validators (is_page_url()/is_database_url()) to accept both www.notion.so and the new app.notion.com domains via a shared _NOTION_DOMAINS allowlist.

Bumps the package version to 1.5.1, adds a changelog entry, and refreshes Notion integration test fixtures/expected outputs to the new app.notion.com/p/... URL format.

Reviewed by Cursor Bugbot for commit ae509e0. Bugbot is set up for automated code reviews on this repo. Configure here.

- Accept both www.notion.so and app.notion.com in is_page_url() and
  is_database_url() after Notion domain migration
- Update integration test fixtures to match new URL format returned
  by the Notion API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants