skip invalid file types for gdrive#715
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Shadow auto-approve: would auto-approve. This PR adds a targeted skip for non-downloadable Google Drive native files and empty files, preventing recurring download errors; the changes are isolated to the Google Drive connector, well-tested, and do not impact core business logic or other connectors.
Re-trigger cubic
Skips invalid shortcut files in google drive downloader. Example:
Summary by cubic
Skip non-downloadable Google Drive files and empty files during indexing and downloading to prevent errors and reduce noise. Exportable Docs/Sheets/Slides still export; unknown native types still error.
GOOGLE_DRIVE_SKIP_MIME_TYPESand_should_skip_fileto drop shortcuts/forms/maps/sites/jam/fusiontable, plusinode/x-emptyand zero-byte files with no MIME.get_paginated_resultsandcount_files_recursively._download_filereturnsNoneandrunreturns[]for skipped files.Written for commit 4e8cef5. Summary will update on new commits. Review in cubic