fix: Return error for invalid PDFs#277
Merged
mpolomdeepsense merged 8 commits intomainfrom Jun 18, 2025
Merged
Conversation
Contributor
mpolomdeepsense
commented
Jun 18, 2025
mpolomdeepsense
commented
- Adds function for checking PDF files before the request gets sent. Throws appropriate error message in case the file is invalid.
mpolomdeepsense
requested review from
awalker4 and
pawel-kmiecik
and removed request for
awalker4
pawel-kmiecik
approved these changes
Jun 18, 2025
Contributor
pawel-kmiecik
left a comment
pawel-kmiecik
left a comment
There was a problem hiding this comment.
Generally looks ok - I'm just worried a bit about the check's influence on the performance (but I think we do these operations in split-pdf function anyway).
| pdf.root_object # pylint: disable=pointless-statement | ||
|
|
||
| # This will raise if the file's pages are corrupted | ||
| list(pdf.pages) |
Contributor
There was a problem hiding this comment.
Did we profiled it for memory/time for large pdfs (like ~1k pages)?
Contributor
Author
There was a problem hiding this comment.
I did not, but maybe we could just check for the first page? I think it will result with the same error. WDYT?
Contributor
Author
There was a problem hiding this comment.
Tested. This does not slow down execution and doesn't affect memory usage, even with big files (tested on 200, 1000 and 10000 pages pdfs).
Results for 10k pages pdf:
mem_profiler_results.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.